Add Core Subtopologies: ComFprime, ComCcsds, DataProducts, FileHandling #3768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check-spelling run (push) for add-subtopologies Signed-off-by: check-spelling-bot <[email protected]> on-behalf-of: @check-spelling <[email protected]>
…nfig clarity improvements
check-spelling run (push) for add-subtopologies Signed-off-by: check-spelling-bot <[email protected]> on-behalf-of: @check-spelling <[email protected]>
check-spelling run (push) for add-subtopologies Signed-off-by: check-spelling-bot <[email protected]> on-behalf-of: @check-spelling <[email protected]>
…ogies, needs cleaning up
Bring add-subtopology branch up to date
LeStarch
requested changes
Jun 21, 2025
… separate config fpp file
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Svc/Subtopologies/ComFprime/ComFprimeConfig/ComFprimeSubtopologyConfig.hpp
Fixed
Show fixed
Hide fixed
Svc/Subtopologies/DataProducts/DataProductsConfig/DataProductsSubtopologyConfig.hpp
Fixed
Show fixed
Hide fixed
LeStarch
approved these changes
Jun 26, 2025
thomas-bc
added
the
Breaking Changes / Needs Release Notes
Significant Features
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Within Svc/Subtopologies, four new subtopologies have been added. ComFprime (Communications stack using FPrime Framing), ComCcsds (Communications stack using Ccsds framing), FileHandling, and DataProducts. Subtopologies integrated within the Reference application, Ref, with the Ccsds subtopology used. Renaming of CDHCore and all references to CdhCore.
ComCcsds Subtopology:
comQueue (Svc::ComQueue)
cmdSeq (Svc::CmdSequencer)
commsBufferManager (Svc::BufferManager)
frameAccumulator (Svc::FrameAccumulator)
fprimeRouter (Svc::FprimeProtocol)
comStub (Svc::ComStub)
tcDeframer (Svc::CCSDS::TcDeframer)
spacePacketDeframer (Svc::CCSDS::SpacePacketDeframer)
tmFramer (Svc::CCSDS:TmFramer)
spacePacketFramer (Svc::CCSDS::SpacePacketFramer)
apidManager (Svc::CCSDS::ApidManager)
comDriver (Drv::TcpClient)
ComFprime Subtopology:
comQueue (Svc::ComQueue)
cmdSeq (Svc::CmdSequencer)
commsBufferManager (Svc::BufferManager)
frameAccumulator (Svc::FrameAccumulator)
deframer (Svc::Deframer)
fprimeFramer (Svc::Framer)
fprimeRouter (Svc::FprimeProtocol)
comStub (Svc::ComStub)
comDriver (Drv::TcpClient)
DataProducts Subtopology
dpBufferManager (Svc::BufferManager)
dpCatalog (Svc::DpCatalog)
dpWriter (Svc::DpWriter)
dpManager (Svc::DpManager)
FileHandling Subtopology
fileUplink (Svc::FileUplink)
fileDownlink (Svc::FileDownlink)
fileManager (Svc::FileManager)
prmDb (Svc::PrmDb)
Rationale
Subtopologies for common FSW stacks can be imported into top level deployment topologies which simplifies the top level directory, and makes maintaining these stacks much simpler across different Test Deployments
Testing/Review Recommendations
Testing done
within Ref/test/intusingpytest ref_integration_test.pyFuture Work
Integration of these subtopologies into current test deployments, restructuring of the cookie-cutter tool to use subtopologies when generating a new project.