Skip to content

Conversation

@Kronos3
Copy link
Collaborator

@Kronos3 Kronos3 commented Jun 9, 2025

This PR puts true FPP interfaces in place of our include "../../[...].fppi"

Closes nasa/fpp#702
Depends on nasa/fpp#736

TODO

  • Point FPP to the new alpha release once we have it

@Kronos3
Copy link
Collaborator Author

Kronos3 commented Jun 11, 2025

@LeStarch / @bocchino This PR breaks some of the examples since the .fppi interfaces are replaced with true FPP interfaces. Do I need to open a https://github.com/nasa/fprime-examples PR before we merge this to make CI pass? If so how does the CI interaction cross-repo work?

@Kronos3 Kronos3 requested review from LeStarch and bocchino June 11, 2025 22:33
@bocchino
Copy link
Collaborator

Do I need to open a https://github.com/nasa/fprime-examples PR before we merge this to make CI pass?

Yes, you should create a PR to the fprime-examples repo with the fix and with following magic prefix in its branch name: pr-3709. That will tell CI here to use the branch there.

@thomas-bc
Copy link
Collaborator

@Kronos3 for the fprime-examples CI you likely need to merge the latest fprime-examples@devel in your pr-xxxx branch

LeStarch
LeStarch previously approved these changes Jun 20, 2025
@LeStarch LeStarch requested a review from thomas-bc June 20, 2025 19:29
@LeStarch
Copy link
Collaborator

@thomas-bc when you have a moment, please review w.r.t the com pipeline stuff.

@ Communication adapter interface implementing communication adapter interface via a Drv.ByteStreamDriverModel.
passive component ComStub {
include "../Interfaces/ComInterface.fppi"
import Com
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a plan to have a keyword specific to implementing an interface in the future? It's not immediately clear to the reader what import Com does if there's no annotation.
Just a thought, not saying we should add comments everywhere.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not planning on adding any syntax to denote implementing an interface besides the import. But yes I agree it's not immediately obvious that import is implementing the interface.

@thomas-bc
Copy link
Collaborator

Reminder: need to merge nasa/fprime-examples#11 when (ideally right before) merging this PR here.

LeStarch
LeStarch previously approved these changes Jun 23, 2025
thomas-bc
thomas-bc previously approved these changes Jun 23, 2025
@Kronos3 Kronos3 dismissed stale reviews from thomas-bc and LeStarch via 17e74a1 June 23, 2025 23:12
@thomas-bc thomas-bc merged commit 5723115 into nasa:devel Jun 24, 2025
70 checks passed
@Kronos3 Kronos3 deleted the interfaces branch June 24, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrate and test port interfaces with F Prime

4 participants