-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Interfaces #3709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interfaces #3709
Conversation
|
@LeStarch / @bocchino This PR breaks some of the examples since the |
Yes, you should create a PR to the fprime-examples repo with the fix and with following magic prefix in its branch name: |
|
@Kronos3 for the |
|
@thomas-bc when you have a moment, please review w.r.t the com pipeline stuff. |
| @ Communication adapter interface implementing communication adapter interface via a Drv.ByteStreamDriverModel. | ||
| passive component ComStub { | ||
| include "../Interfaces/ComInterface.fppi" | ||
| import Com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a plan to have a keyword specific to implementing an interface in the future? It's not immediately clear to the reader what import Com does if there's no annotation.
Just a thought, not saying we should add comments everywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are not planning on adding any syntax to denote implementing an interface besides the import. But yes I agree it's not immediately obvious that import is implementing the interface.
|
Reminder: need to merge nasa/fprime-examples#11 when (ideally right before) merging this PR here. |
This PR puts true FPP interfaces in place of our
include "../../[...].fppi"Closes nasa/fpp#702
Depends on nasa/fpp#736
TODO