-
Notifications
You must be signed in to change notification settings - Fork 46
Add support for externally stored parameters #707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add external parameters to the spec and syntax
… instead of a parameter buffer
Co-authored-by: Rob Bocchino <[email protected]>
Co-authored-by: Rob Bocchino <[email protected]>
Ensure that variables are initialized
Silence compiler warnings on clang
Rename variables
Rename variables; add static casts
Rename variables
Rename variables Add static casts
External parameters component code generation and unit test
Conflicts: compiler/lib/src/main/scala/codegen/CppWriter/ComponentCppWriter/ComponentCppWriter.scala compiler/lib/src/main/scala/syntax/Lexer.scala compiler/lib/src/main/scala/syntax/Parser.scala
3 tasks
bocchino
approved these changes
May 14, 2025
Collaborator
bocchino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fpp implementation of supporting externally managed parameters #637. Includes the following issues: