Skip to content

External parameters component code generation and unit test #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 62 commits into from
Apr 30, 2025
Merged

External parameters component code generation and unit test #682

merged 62 commits into from
Apr 30, 2025

Conversation

@Brian-Campuzano
Copy link
Collaborator

@Brian-Campuzano Brian-Campuzano commented Apr 15, 2025

Closes #640
Closes #643

@Brian-Campuzano
Added isExternal to parameter analysis class
7325a1c
@Brian-Campuzano
Merge branch 'extern_params' into extern_params_codegen
c3b7051
@Brian-Campuzano
Updated loadParameters for external parameters
b7c4dde
@Brian-Campuzano
Added parameter serialization/deserization function pointer construto…
8eacea4 
…r arguments
@Brian-Campuzano
Added parameter function pointer initialization
7da5bcd
@Brian-Campuzano
Function pointer prototype
912ca63
@Brian-Campuzano
Merge branch 'feature/external-params' into extern_params_codegen
489cb0c
@Brian-Campuzano
Updated external parameter conditionals to use guardedList()
f670eed
@Brian-Campuzano
Refactored to use an abstract base class
3775f10
@Brian-Campuzano
Merge branch 'feature/external-params' into extern_params_codegen
8c5effd
@Brian-Campuzano
Added external parameter saving implementation
b145a00
@Brian-Campuzano
Updated external parameter tests
d75aef6
@Brian-Campuzano
Restored parameter loaded call
5043d69
@Brian-Campuzano
Add check to ensure the ~/projects/fprime path is absolute
ef5adc6
@Brian-Campuzano
Added current FPRIME env to error message
130e2c3
@Brian-Campuzano
Fixed parameter compilation
cc3719f
@Brian-Campuzano
Updated paramSave function for external parameters
61ba0da
@Brian-Campuzano
Handle the serilization status in loadParameters
6e3cd9d
@Brian-Campuzano
Updated the deserializeParam() calls to include param validity
d1e1032
@Brian-Campuzano
Only base the raw parameter ID to the parameter delegate without the …
0ad2e2f 
…base ID
@Brian-Campuzano
Removed the external parameter valid and storage member variables. Al…
3d23db7 
…so implmented the external paramGet_* function
@Brian-Campuzano
Merge branch 'feature/external-params' into extern_params_codegen
7f41c10
@Brian-Campuzano
Added serialize/deserialize UT functions
f952d2f
@Brian-Campuzano
Added external parameter delegate instance to UT tester class
60e70cf
@Brian-Campuzano
Moved parameter delegate initialization to the base component constru…
89eb49e 
…ctor
@Brian-Campuzano
Fixed const correctness
16a7a32
@Brian-Campuzano
Updated external parameter usage in tester base class
ef54520
@Brian-Campuzano
Additional UT constructor argument updates
d234648
@Brian-Campuzano
Additional delegate init tweaks, needs a meeting to decide path forward
e62b622
@Brian-Campuzano
Updates to the tester implementation of external parameter delegates
d81cc3f
@Brian-Campuzano
Copy link
Collaborator Author

Brian-Campuzano commented Apr 28, 2025

@bocchino I have addressed all comments and this PR is ready to be merged.

@bocchino bocchino self-requested a review April 29, 2025 00:25
@bocchino
Copy link
Collaborator

bocchino commented Apr 29, 2025

Looks good so far! When running check-cpp against nasa/fprime/devel, I get this error:

In file included from ActiveExternalParamsComponentAc.cpp:12:
../base/ActiveExternalParamsComponentAc.hpp:27:10: fatal error: 'Fw/Prm/PrmExternalTypes.hpp' file not found
   27 | #include "Fw/Prm/PrmExternalTypes.hpp"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Is there another branch of fprime to use to run check-cpp?

@bocchino
Copy link
Collaborator

bocchino commented Apr 29, 2025 •
edited
Loading

Or possibly is a file not checked in to fprime/Fw/Prm in the fpp-to-cpp test area?

@Brian-Campuzano
Copy link
Collaborator Author

Brian-Campuzano commented Apr 29, 2025

@bocchino my fprime changes are staged on https://github.com/Brian-Campuzano/fprime/tree/extern_params

@bocchino
Copy link
Collaborator

bocchino commented Apr 29, 2025

@bocchino my fprime changes are staged on https://github.com/Brian-Campuzano/fprime/tree/extern_params

Got it, thanks!

bocchino added 8 commits April 29, 2025 10:36
@bocchino
Revise param code gen
477b018 
Ensure that variables are initialized
@bocchino
Revise parameter code gen
0230ab5 
Silence compiler warnings on clang
@bocchino
Revise parameter code gen
d2af41c 
Rename variables
@bocchino
Revise param code gen
819e20e 
Rename variables; add static casts
@bocchino
Revise parameter code gen
4aeb090 
Rename variables
@bocchino
Revise parameter code gen
74c5bfd 
Rename variables
Add static casts
@bocchino
Refactor param code gen
0a4f681
@bocchino
Refactor param code gen
5ae491b
bocchino
bocchino approved these changes Apr 30, 2025
View reviewed changes
Copy link
Collaborator

@bocchino bocchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I did a little refactoring in the Scala and the generated code.

@bocchino bocchino merged commit 69dadf8 into feature/external-params Apr 30, 2025
@bocchino bocchino deleted the extern_params_codegen branch April 30, 2025 00:03
This was referenced May 13, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bocchino bocchino bocchino approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Brian-Campuzano @bocchino