Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Sep 27, 2025

Describe your changes

Closes #4714

  • When dry-running, dummy signatures are used in txs
  • Validation does not perform signature checks when dry-running

I have tested that the gas estimation hasn't changed between dry-running with signatures and with dummies. It is curious however that in both cases there is a small discrepancy between dry-running and the actual tx.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

This is an automatic backport of pull request #4832 done by [Mergify](https://mergify.com).

…erent sig verify logic

(cherry picked from commit e069e81)
(cherry picked from commit 0b72a14)
@mergify
Copy link
Contributor Author

mergify bot commented Sep 27, 2025

🧪 CI Insights

Here's what we observed from your CI run for 356254f.

🟢 All jobs passed!

But CI Insights is watching 👀

@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Sep 28, 2025
@codecov
Copy link

codecov bot commented Sep 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@mergify mergify bot added the queued label Sep 28, 2025
@mergify mergify bot merged commit 40be69d into maint-201.0 Sep 28, 2025
23 of 24 checks passed
@mergify mergify bot removed the queued label Sep 28, 2025
@mergify mergify bot deleted the mergify/bp/maint-201.0/pr-4832 branch September 28, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants