-
Notifications
You must be signed in to change notification settings - Fork 1k
Dry run with mock sigs #4832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dry run with mock sigs #4832
Conversation
🧪 CI InsightsHere's what we observed from your CI run for 0b72a14. ✅ Passed Jobs With Interesting Signals
|
|
The changes look great but I think we'll need to find where the discrepancy comes from as we need this feature for more accurate gas estimation |
I'm not sure how this feature is supposed to give more accurate gas estimation unless you mean that we can now dry-run txs that require a hardware wallet to sign. In any case, this discrepancy existed before these changes and it seems from my limited testing that these changes preserve the values for both the dry-run and actual run. The difference is like 100 - 200 gas units, and the dry-runs are higher than the actual. |
Ah, it's aimed for the interface where we need to estimate gas cost before signing, mostly for the txs that have very variable gas cost depending on the execution path (e.g. PoS redelegation). But if the dry-run estimates are a bit higher I think that's acceptable |
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You can check the last failing draft PR here: #4838. You may have to fix your CI before adding the pull request to the queue again. |
|
Hey @batconjurer, your pull request has been dequeued due to the following reason: CHECKS_FAILED. |
|
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You can check the last failing draft PR here: #4840. You may have to fix your CI before adding the pull request to the queue again. |
|
Hey @batconjurer, your pull request has been dequeued due to the following reason: CHECKS_FAILED. |
|
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You can check the last failing draft PR here: #4841. You may have to fix your CI before adding the pull request to the queue again. |
|
Hey @batconjurer, your pull request has been dequeued due to the following reason: CHECKS_FAILED. |
|
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You can check the last failing draft PR here: #4869. You may have to fix your CI before adding the pull request to the queue again. |
|
Hey @batconjurer, your pull request has been dequeued due to the following reason: CHECKS_FAILED. |
|
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You can check the last failing draft PR here: #4870. You may have to fix your CI before adding the pull request to the queue again. |
|
Hey @batconjurer, your pull request has been dequeued due to the following reason: CHECKS_FAILED. |
|
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
Dry run with mock sigs (backport #4832)
|
I'm backporting this to libs as #4816 depends on it for some mocking fns |
…pr-4832 Dry run with mock sigs (backport #4832)
Describe your changes
Closes #4714
I have tested that the gas estimation hasn't changed between dry-running with signatures and with dummies. It is curious however that in both cases there is a small discrepancy between dry-running and the actual tx.
Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo