-
Notifications
You must be signed in to change notification settings - Fork 1k
Nondegenerate multisignature hardware wallets #1884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c1aafa9 to
3c7bdba
Compare
| let amt_verified = usize::from(amt_verifieds.is_err()) | ||
| + verified_pks.len() | ||
| - prev_verifieds; | ||
| x.consume(VERIFY_TX_SIG_GAS_COST * amt_verified as u64) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that given this rework it would be slightly better to move the gas accounting part directly into the verify_signature method of Signature, to have a highest possible resolution. But we can do this later
grarco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
998fd82 to
6eff4a9
Compare
* origin/murisi/multisig-fixes: Added changelog entry. Added support for compressed signatures coming from hardware wallets. Combining Signature and MultiSignature sections to deduplicate hardware wallet code. Allow public key to be specified in signature section.
Describe your changes
namada-interface(we should explore in future whether this can be used to reduce size of signature sections on protocol)Indicate on which release or other PRs this topic is based on
Namada v0.22.0
Checklist before merging to
draft