Update Ledger signing for multisig changes #388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurevans
force-pushed
the
chore/update-ledger-multisig-fixes
branch
from
1dc4b77 to
244763f
Compare
Contributor
jurevans
force-pushed
the
chore/update-ledger-multisig-fixes
branch
from
244763f to
9de593b
Compare
jurevans
force-pushed
the
chore/update-ledger-multisig-fixes
branch
3 times, most recently
from
2bcb7b8 to
8428422
Compare
jurevans
force-pushed
the
chore/update-ledger-multisig-fixes
branch
from
8428422 to
aff46f9
Compare
jurevans
changed the title
jurevans
changed the title
jurevans
force-pushed
the
chore/update-ledger-multisig-fixes
branch
from
f57018f to
35365cc
Compare
mateuszjasiuk
approved these changes
Sep 18, 2023
Collaborator
mateuszjasiuk
left a comment
mateuszjasiuk
left a comment
There was a problem hiding this comment.
LGTM! tested with transfer and staking stuff
jurevans
force-pushed
the
chore/update-ledger-multisig-fixes
branch
from
35365cc to
bc783b5
Compare
jurevans
force-pushed
the
chore/update-ledger-multisig-fixes
branch
from
bc783b5 to
dab5a05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE We should wait to merge this until these changes are in the next release!
Update Ledger signing to support changes in namada-net/namada#1884 (now in Zondax/ledger-namada#10). The logic for decompressing signatures for Ledger have been moved into Namada, in the
CompressedSignaturestruct, where we can invokeexpand(&tx)to retrieve the full signature sections. Also, IBC is now enabled for signing on Ledger. See me for the correct version of the ledger app!TESTING This must be tested against a chain running
murisi/multisig-fixes.RevealPKTransferBondUnbondWithdrawIBC Transfer