Murisi/draft with masp generic amounts rebased #1844
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* origin/grarco/variable-fees: changelog: #1327 [ci] wasm checksums update Keep write log changes before fee unshield failure in `charge_fee` Changes `dev` feature to `testing` Adds check on masp gas payer Fixes broken fee optimization logic in cli. Fixes fee unshielding logic in ledger Saves optional disposable keypair to wallet Moves disposable signing key generation to wallet module Improves fee-related logs in the client Renames fees cli arguments Fixes gas in tests Renames fee payers cli arguments Refactors `get_tx_fee` to avoid using `Uint` Fixes `fee_amount` parsing Reduces the scale of the gas sub-units Adds gas and fees protocol parameters to query response Updates visibility of functions Adds fee unshielding integration test. Updates other tests Adds disposable signer e2e test. Updates other tests Updates gas meters in tests Updates e2e tests Misc adjustments for testing Adds disposable wrapper signer. Adjusts tx construction for fees Sdk functions to return the optional `Epoch` for fee unshielding Handles wrapper's signer separately Renames `gas_payer` to `fee_payer` Reworks wasm compilation step. Accepts `floats` wasm feature Dry-run wrapper tx Updates gas meter objects initializations Helper storage functions to construct fee unshielding tx in protocol `ShellParams` carries a generic wl_storage. Reworks `dispatch_tx` to charge fees and adds related functions Adds spare gas for each tx in the storage queue Updates gas computation with multipliers Removes masp fees + gas for the vp Fixes `clean-wasm` step of wasm Makefile Updates wasm vps with gas and host sig verification Gas metering for sig verification Renames gas function and adds exposed function for signatures' verification Exposes wasm functions for consuming gas Whitelisted gas in wasm Adds benchmarks crate for gas `process_proposal` validates gas & fees `prepare_proposal` validates gas & fee. Extracts validation to a separate method Renames `BlockAllocator` and makes it track gas too Updates unit tests for mandatory block proposer Reviews `ErrorCodes`. Adds fee validation function Always expects a block proposer. Moves `WrapperTx` handling inside `dispatch_tx` Adds new CLI arguments for gas & fee Adds core methods for fee unshielding. Brings back `GasLimit` to `u64` Adds a precommit write log to `WriteLog`. Adjusts gas accounting with multipliers Adds `split_borrow` method to `WriteLogAndStorage` trait Adds gas and fee protocol parameters Reworks `gas` module. Introduces `GasMetering` trait and gas sub-units
* origin/tomas/feature-guard-masp-proofs-load: changelog: add #1828 shared/types/control_flow: fix warn when no-default-features shared/ledger/masp: "testing" feature guard proofs load/save make check-crates: check that shared can build for wasm target
* origin/gijs/custom-height-db-dump: changelog: #1468 Buffer write for db-dump. Changes arg to ownership `dump-db` custom height
* origin/fraccaman/pgf: pgf: minor fixes e2e: fix pgf test pgf: added vp pgf validation pgf: minor fixes, added basic tests pgf: added resign and update steward reward txs multisig: fix hashes ordering pgf: rework fundings storage pgf: improve storage api, fix tallying client: refactor router, fix minor ui issues
murisi
force-pushed
the
murisi/draft-with-masp-generic-amounts-rebased
branch
from
e158371 to
fed7f3c
Compare
Contributor
|
Is this still needed or was part of this merged in v0.22.0? |
Collaborator
Author
|
Yes, this has essentially been merged. It's just that we used this branch instead: #1842 (comment) . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Indicate on which release or other PRs this topic is based on
Checklist before merging to
draft