pgf: v2 #1838
Merged
pgf: v2 #1838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fraccaman
force-pushed
the
fraccaman/pgf
branch
from
8ae2e68 to
c711f20
Compare
Fraccaman
force-pushed
the
fraccaman/pgf
branch
from
c711f20 to
6871d4b
Compare
grarco
reviewed
Aug 24, 2023
| &funding.detail.target, | ||
| ); | ||
| } else { | ||
| tracing::info!( |
Collaborator
There was a problem hiding this comment.
Should we log this at a different level to make it stand out?
Collaborator
Author
There was a problem hiding this comment.
good point, maybe warn is better
grarco
reviewed
Aug 24, 2023
| address, | ||
| ); | ||
| } else { | ||
| tracing::info!( |
Collaborator
There was a problem hiding this comment.
Same question as before for the log level
grarco
reviewed
Aug 24, 2023
| for (address, percentage) in steward.reward_distribution { | ||
| let pgf_steward_reward = pgf_steward_reward | ||
| .checked_mul(&percentage) | ||
| .unwrap_or_default(); |
Collaborator
There was a problem hiding this comment.
Should we log something in case of an overflow?
Collaborator
Author
There was a problem hiding this comment.
this can never happen cause percentage is between 0 and 1
grarco
reviewed
Aug 24, 2023
shared/src/ledger/tx.rs
Outdated
| }: args::ResignSteward, | ||
| gas_payer: &common::PublicKey, | ||
| ) -> Result<Tx, Error> { | ||
| // if !rpc::is_steward(client, &steward).await && !tx_args.force { |
Collaborator
There was a problem hiding this comment.
Don't we need these checks?
Collaborator
Author
There was a problem hiding this comment.
we need them, you are right!
grarco
reviewed
Aug 24, 2023
| } | ||
| } | ||
|
|
||
| /// Get governane parameters |
Collaborator
There was a problem hiding this comment.
Typo
Suggested change
| /// Get governane parameters | |
| /// Get governance parameters |
grarco
reviewed
Aug 24, 2023
core/src/types/uint.rs
Outdated
Comment on lines
449
to
450
| let is_negative = (self.is_negative() || v.is_negative()) | ||
| && !(self.is_negative() && v.is_negative()); |
Collaborator
There was a problem hiding this comment.
I think you can write this as
Suggested change
| let is_negative = (self.is_negative() || v.is_negative()) | |
| && !(self.is_negative() && v.is_negative()); | |
| let is_negative = self.is_negative() != v.is_negative(); |
grarco
previously approved these changes
Aug 24, 2023
Collaborator
grarco
left a comment
grarco
left a comment
There was a problem hiding this comment.
Minor comments but looks good to me, thanks!
Fraccaman
force-pushed
the
fraccaman/pgf
branch
from
5ae0df5 to
ef6a161
Compare
Closed
Fraccaman
force-pushed
the
fraccaman/pgf
branch
from
ef6a161 to
0851f54
Compare
Fraccaman
force-pushed
the
fraccaman/pgf
branch
from
0851f54 to
84cf6ed
Compare
Fraccaman
added a commit
that referenced
this pull request
Aug 28, 2023
* origin/fraccaman/pgf: pgf: minor fixes e2e: fix pgf test pgf: added vp pgf validation pgf: minor fixes, added basic tests pgf: added resign and update steward reward txs multisig: fix hashes ordering pgf: rework fundings storage pgf: improve storage api, fix tallying client: refactor router, fix minor ui issues
Fraccaman
added a commit
that referenced
this pull request
Sep 6, 2023
* origin/fraccaman/pgf: pgf: minor fixes e2e: fix pgf test pgf: added vp pgf validation pgf: minor fixes, added basic tests pgf: added resign and update steward reward txs multisig: fix hashes ordering pgf: rework fundings storage pgf: improve storage api, fix tallying client: refactor router, fix minor ui issues
Fraccaman
added a commit
that referenced
this pull request
Sep 6, 2023
* origin/fraccaman/pgf: pgf: minor fixes e2e: fix pgf test pgf: added vp pgf validation pgf: minor fixes, added basic tests pgf: added resign and update steward reward txs multisig: fix hashes ordering pgf: rework fundings storage pgf: improve storage api, fix tallying client: refactor router, fix minor ui issues
Fraccaman
added a commit
that referenced
this pull request
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Indicate on which release or other PRs this topic is based on
0.21.1
Checklist before merging to
draft