Change to multitokens #1663
Closed
Change to multitokens #1663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batconjurer
reviewed
Jul 6, 2023
Collaborator
batconjurer
left a comment
batconjurer
left a comment
There was a problem hiding this comment.
So far, this looks like an enormous improvement
sug0
reviewed
Jul 6, 2023
Collaborator
sug0
left a comment
sug0
left a comment
There was a problem hiding this comment.
first few comments, may add more later
Comment on lines
+466
to
+474
| .filter_map(|(t, o, s)| match (token, target) { | ||
| (Some(token), Some(target)) if t == *token && o == *target => { | ||
| Some((t, s)) | ||
| } | ||
| (Some(token), None) if t == *token => Some((t, s)), | ||
| (None, Some(target)) if o == *target => Some((t, s)), | ||
| (None, None) => Some((t, s)), | ||
| _ => None, | ||
| }) |
Collaborator
There was a problem hiding this comment.
can we document the purpose of each of these match arms? reading this code is hard, especially with these short identifiers (i.e. t, o and s), which have no immediate meaning
| let denom_key = storage::ibc_denom_key(token_hash); | ||
| let denom = match self.ctx.borrow().read(&denom_key) { | ||
| Ok(Some(v)) => String::from_utf8(v).map_err(|e| { | ||
| Ok(Some(v)) => String::try_from_slice(&v[..]).map_err(|e| { |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renew balance keys with
Multitoken#Multitoken/{token_addr}/balance/{owner}#Multitoken/{token_addr}/balance/mintedAdd Multitoken VP
shared/src/ledger/native_vp/multitoken.rsRemove
sub_prefixIBC: Clean up with Multitokens
#Multitoken/#IbcToken(hash)/balance/{owner}EthBridge: Change the balance keys
#Multitoken/#Erc20(eth_addr)/balance/{owner}#Multitoken/#Erc20(eth_addr)/balance/minted