examples: Add image_pub_sub#629
Open
furushchev wants to merge 1 commit into
Open
Conversation
furushchev
force-pushed
the
image-transport-example-test
branch
2 times, most recently
from
5664ab8 to
9602c27
Compare
Author
|
@mvukov I'm using the hermetic LLVM toolchain to build the libraries and it needs to add Q1: Is there any way to add test examples workspace with LLVM toolchain enabled in addition to the default GCC toolchain? |
Owner
Yup. |
mvukov
reviewed
May 17, 2026
Owner
mvukov
left a comment
mvukov
left a comment
There was a problem hiding this comment.
examples/image_pub_sub/image_pub_sub.test.py -> image_pub_sub_tests.py.
Per the Google style guide: C++ headers should have .h extension.
Nice work, I left some comments.
furushchev
force-pushed
the
image-transport-example-test
branch
from
9602c27 to
0c8b777
Compare
Author
|
@mvukov Thanks for the review. I addressed things on your comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
examples/image_pub_subsubdirectory where example image transport plugins are registered and used for the test to verify the transport plugin works.With another test
ros2/test/image_common, it ensures the plugin mechanism works in downstream workspace.