Add missing imports attributes to py_library targets#625
Open
linzhp wants to merge 3 commits into
Open
Conversation
mvukov
approved these changes
May 17, 2026
Owner
|
BTW, please document the rationale for those extra imports at all places. |
Author
|
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing imports attributes to py_library targets so aspect_rules_py's
pth generator adds the correct repo roots to sys.path. rules_python's
py_test launcher populates PYTHONPATH from all transitive sources, making
these importable even without explicit imports; aspect_rules_py's venv-based
py_test only emits .pth entries for targets with an explicit imports
attribute, so targets without one are invisible to the venv runner.