proto <> ros functionality#611
Draft
mvukov wants to merge 22 commits into
Draft
Conversation
Owner
Author
|
Also, one item high on my wish list is to add some option annotations to be able to define fixed-size arrays on the ROS side (such that one can use zero-copy transport in ROS on generated msgs). |
- when multiple files in the same proto target - when proto file name has underscores
e24ee8f to
75bcd02
Compare
8a645b7 to
8b52ab2
Compare
e1a56f9 to
1c1b1f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cf. #500 and #605.
Given a, let's say, "public" API in protos (that you could use in backend), this PR allows you to have equivalent msg type to use them in ROS. Plus, adds converters.
Adds support for:
This is a Bazel-native solution that (again) leverages Bazel aspects. In other words, Bazel takes care that code generation is properly done through the dependency graph. TBH, didn't look into proto2ros closely, but I saw possible issues in dependency propagation when working with Bazel.
The code is messy, brother Claude and I hacked this up in a short amount of time.
TODOs:
Support for other languages, such as Rust and Python -> follow-up.
@uhlajs @Skeleton003 Is this something you're looking for? There are no docs yet, you can take a look at ros2/test/protobuf/converter_tests.cc. Any specific functionality you're looking at?