Fix measure number collides with bracket #30771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should use effectiveStaffIdx as opposed to checking its "original" staff because staves may be hidden in between.
miiizen
approved these changes
Oct 28, 2025
its-not-nice
approved these changes
Oct 30, 2025
Merged
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 7, 2025
Follow up to musescore#30771, not works also when measure numbers are below the staff Resolvers musescore#30707
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 7, 2025
Follow up to musescore#30771, not works also when measure numbers are below the staff Resolves: musescore#30707
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 7, 2025
Follow up to musescore#30771, now also works when measure numbers are below the staff Resolves: musescore#30707
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 7, 2025
Follow up to musescore#30771, now also works when measure numbers are below the staff Resolves: musescore#30707
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #30707
Should use effectiveStaffIdx as opposed to checking its "original" staff because staves may be hidden in between.