Skip to content

[4.6.0] fixed #30150: MacOS Voiceover crash on selecting done after adding an instrument #30153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2025
Merged

[4.6.0] fixed #30150: MacOS Voiceover crash on selecting done after adding an instrument #30153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions src/notation/qml/MuseScore/NotationScene/UndoHistoryPanel.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,33 +30,32 @@ import MuseScore.NotationScene
Item {
id: root

property alias navigationSection: navPanel.section
property alias navigationOrderStart: navPanel.order

NavigationPanel {
id: navPanel
name: "Undo/redo history"
direction: NavigationPanel.Vertical
Copy link
Member

@cbjeukendrup cbjeukendrup Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to set this? (default is horizontal)

Copy link
Contributor Author

@Eism Eism Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no real difference, navigation works the same for them

enabled: root.enabled && root.visible
}
property var navigationSection: null
property int navigationOrderStart: 0

StyledListView {
id: listView

objectName: "Undo/redo history"

anchors.fill: parent

currentIndex: undoHistoryModel.currentIndex

navigation.section: root.navigationSection
navigation.order: root.navigationOrderStart

model: UndoHistoryModel {
id: undoHistoryModel
}

currentIndex: undoHistoryModel.currentIndex

delegate: ListItemBlank {
id: listItem
isSelected: ListView.isCurrentItem

readonly property bool isRedoable: model.index > undoHistoryModel.currentIndex

navigation.panel: navPanel
navigation.panel: listView.navigation
navigation.order: model.index
navigation.accessible.name: model.text
navigation.accessible.row: model.index
Expand Down
Loading