[4.6.0] fixed #30150: MacOS Voiceover crash on selecting done after adding an instrument #30153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eism
force-pushed
the
undo_panel_crash_fix_4.6
branch
from
eaedfef to
ef2ef5e
Compare
| NavigationPanel { | ||
| id: navPanel | ||
| name: "Undo/redo history" | ||
| direction: NavigationPanel.Vertical |
Member
There was a problem hiding this comment.
Don't we need to set this? (default is horizontal)
Contributor
Author
There was a problem hiding this comment.
There is no real difference, navigation works the same for them
cbjeukendrup
approved these changes
Sep 26, 2025
Member
cbjeukendrup
left a comment
cbjeukendrup
left a comment
There was a problem hiding this comment.
Approving for now, although we are not completely sure yet why this fixes it and whether other places need the same treatment
Contributor
|
Tested on MacOS 15, Windows 11, Ubuntu 22.04.3. Approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #30150