Open
Conversation
Pururun
changed the title
If it is set to sticky it could cause unintended behavior in some cases.
Pururun
force-pushed
the
frequent-disconnected-notifications-from-mullvad-android-app-droid-2210
branch
from
d308ed3 to
1f021d0
Compare
Rawa
requested changes
Nov 11, 2025
Collaborator
Rawa
left a comment
Rawa
left a comment
There was a problem hiding this comment.
@Rawa reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion
android/service/src/main/kotlin/net/mullvad/mullvadvpn/service/MullvadVpnService.kt line 136 at r1 (raw file):
} return START_NOT_STICKY
I'm think we need to think this through a bit more. According to https://stackoverflow.com/a/9441795 this should only apply when memory runs out. I'm not sure if it is true or not. But we should investigate if it is the correct route to go.
Pururun
added
the
On hold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If it is set to sticky it could cause unintended behavior in some cases.
To be more precise the service would restart over and over again even though the app was disconnected.
This has been tested for the one user that reported this behavior, just needs to make sure that it does not break any normal behavior.
This change is