Set MullvadVPNService as non-sticky

Pururun · Pururun · commit 1f021d0dfce6 · 2025-11-10T16:17:54.000+01:00
If it is set to sticky it could cause unintended behavior in some cases.
diff --git a/android/service/src/main/kotlin/net/mullvad/mullvadvpn/service/MullvadVpnService.kt b/android/service/src/main/kotlin/net/mullvad/mullvadvpn/service/MullvadVpnService.kt
@@ -104,7 +104,7 @@ class MullvadVpnService : TalpidVpnService() {
             "onStartCommand (intent=$intent, action=${intent?.action}, flags=$flags, startId=$startId)"
         )
 
-        val startResult = super.onStartCommand(intent, flags, startId)
+        super.onStartCommand(intent, flags, startId)
 
         // Always promote to foreground if connect/disconnect actions are provided to mitigate cases
         // where the service would potentially otherwise be too slow running `startForeground`.
@@ -133,7 +133,7 @@ class MullvadVpnService : TalpidVpnService() {
             }
         }
 
-        return startResult
+        return START_NOT_STICKY
     }
 
     override fun onBind(intent: Intent?): IBinder {

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ class MullvadVpnService : TalpidVpnService() {`
`104`	`104`	`"onStartCommand (intent=$intent, action=${intent?.action}, flags=$flags, startId=$startId)"`
`105`	`105`	`)`
`106`	`106`
`107`		`- val startResult = super.onStartCommand(intent, flags, startId)`
	`107`	`+ super.onStartCommand(intent, flags, startId)`
`108`	`108`
`109`	`109`	`// Always promote to foreground if connect/disconnect actions are provided to mitigate cases`
`110`	`110`	// where the service would potentially otherwise be too slow running `startForeground`.
`@@ -133,7 +133,7 @@ class MullvadVpnService : TalpidVpnService() {`
`133`	`133`	`}`
`134`	`134`	`}`
`135`	`135`
`136`		`- return startResult`
	`136`	`+ return START_NOT_STICKY`
`137`	`137`	`}`
`138`	`138`
`139`	`139`	`override fun onBind(intent: Intent?): IBinder {`