GPUStatsPanel: Clean up, add ability to customize precision to stats #27361
Conversation
|
|
||
| dom: canvas, | ||
|
|
||
| getDisplayValue: round, |
There was a problem hiding this comment.
I'm fine with making this change but we should clarify how to move on with cases when files in jsm/libs require a modification.
Normally, these files are just copied over and considered as read-only. If we modify them, they get out of sync compared to the original module. In this case: https://github.com/mrdoob/stats.js. The ideal workflow would be to modify the source in https://github.com/mrdoob/stats.js, make a release and then use the new build in three.js.
This workflow could be enforce by just deleting examples/jsm/libs/stats.module.js and import it directly from https://github.com/mrdoob/stats.js with a CDN like other external libs.
There was a problem hiding this comment.
Sorry I forgot to mention that - I agree. @mrdoob what's your preference here?
|
|
2 participants
Related issue: #27347
Description
As suggested in #27347 it might make sense to adjust stats.js to display more values of precision by default and make it display average value over time. And maybe expand the width of the stats panel to ~90-100 px so the min / max values can all be displayed.
cc @RenaudRohlinger