WebGLAttributes: Strict buffer size check when updating data. #27188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strict check for buffer size while upload..
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
eXponenta
changed the title
Implement the check even more strict. Clarify error message.
Mugen87
changed the title
Collaborator
|
I've update the code too make the check even more strict. |
This was referenced Nov 18, 2023
AdaRoseCannon
pushed a commit
to AdaRoseCannon/three.js
that referenced
this pull request
Jan 15, 2024
…#27188) * Update WebGLAttributes.js Strict check for buffer size while upload.. * fix: lint, pads * Update WebGLAttributes.js Implement the check even more strict. Clarify error message. * Update WebGLAttributes.js * Update WebGLAttributes.js Fix typo. --------- Co-authored-by: Michael Herzog <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strict check for buffer size while upload..
Related issue: #27180