Skip to content

HTMLMesh: Fix canvas cache usage. #24650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2022
Merged

HTMLMesh: Fix canvas cache usage. #24650

merged 1 commit into from
Sep 19, 2022

Conversation

@Degubi
Copy link
Contributor

@Degubi Degubi commented Sep 16, 2022 •
edited by Mugen87
Loading

Related issue: #22098

Description

  • Fix only reading, but not updating the canvas cache
  • Avoid double lookups when reading from the canvas cache

@Degubi Degubi changed the title Fix HTMLMesh canvases cache usage Fix HTMLMesh canvas cache usage Sep 16, 2022
@Degubi Degubi mentioned this pull request Sep 16, 2022
Merged
@Degubi Degubi changed the title Fix HTMLMesh canvas cache usage Fix & improve HTMLMesh canvas cache usage Sep 16, 2022
@Mugen87 Mugen87 added this to the r145 milestone Sep 16, 2022
@Mugen87 Mugen87 changed the title Fix & improve HTMLMesh canvas cache usage HTMLMesh: Fix canvas cache usage. Sep 16, 2022
@Mugen87 Mugen87 merged commit b354e68 into mrdoob:dev Sep 19, 2022
@Degubi Degubi deleted the HTMLMesh_canvases_cache_cleanup branch September 19, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r145

Development

Successfully merging this pull request may close these issues.

2 participants

@Degubi @Mugen87