Skip to content

Commit b354e68

Browse files
authored
Fix HTMLMesh canvases cache usage (#24650)
1 parent 4844199 commit b354e68

File tree

2 files changed

+6
-12
lines changed

2 files changed

+6
-12
lines changed

examples/js/interactive/HTMLMesh.js

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -430,17 +430,14 @@
430430
}
431431

432432
const offset = element.getBoundingClientRect();
433-
let canvas;
433+
let canvas = canvases.get( element );
434434

435-
if ( canvases.has( element ) ) {
436-
437-
canvas = canvases.get( element );
438-
439-
} else {
435+
if ( canvas === undefined ) {
440436

441437
canvas = document.createElement( 'canvas' );
442438
canvas.width = offset.width;
443439
canvas.height = offset.height;
440+
canvases.set( element, canvas );
444441

445442
}
446443

examples/jsm/interactive/HTMLMesh.js

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -469,17 +469,14 @@ function html2canvas( element ) {
469469

470470
const offset = element.getBoundingClientRect();
471471

472-
let canvas;
472+
let canvas = canvases.get( element );
473473

474-
if ( canvases.has( element ) ) {
475-
476-
canvas = canvases.get( element );
477-
478-
} else {
474+
if ( canvas === undefined ) {
479475

480476
canvas = document.createElement( 'canvas' );
481477
canvas.width = offset.width;
482478
canvas.height = offset.height;
479+
canvases.set( element, canvas );
483480

484481
}
485482

0 commit comments

Comments
 (0)