Skip to content

Object3D: Clarify .attach() limitations #22821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2021
Merged

Object3D: Clarify .attach() limitations #22821

merged 1 commit into from
Nov 12, 2021

Conversation

@WestLangley
Copy link
Collaborator

@WestLangley WestLangley commented Nov 12, 2021

Fixes #22769.

@WestLangley
Copy link
Collaborator Author

WestLangley commented Nov 12, 2021

@Mugen87 I think this is sufficient... :-)

The only other library methods that call decompose() are getWorldQuaternion() and getWorldScale(). I would not worry about them for now...

@WestLangley
Copy link
Collaborator Author

WestLangley commented Nov 12, 2021

Related: #22810 (comment)

@mrdoob mrdoob added this to the r135 milestone Nov 12, 2021
@mrdoob mrdoob merged commit 6258b52 into mrdoob:dev Nov 12, 2021
@mrdoob
Copy link
Owner

mrdoob commented Nov 12, 2021

Thanks!

@WestLangley WestLangley deleted the dev_attach branch November 17, 2021 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r135

Development

Successfully merging this pull request may close these issues.

Object3D.attach: Rotated child inside non-uniformly scaled parent causes issues

3 participants

@WestLangley @mrdoob @Mugen87