feat: Split google into gemini and vertexai #401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
... and 77 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Contributor
Author
|
Integration tests: https://github.com/mozilla-ai/any-llm/actions/runs/17496041001 We are flying blind for VertexAI because we don't have the API keys for that yet. But we do have them for Gemini so at least that part is tested in the integration test. This PR should also make it easier to help users debug, since then we'll know right away whether they're using vertex or gemini |
daavoo
added a commit
that referenced
this pull request
Sep 8, 2025
In #401 we stopped overriding `Provider.__init__` and thus we started to rely again on the default `Provider._verify_and_set_api_key`. We need to provide a custom implementation that checks for both API key options instead of the plain string with a `/`. - Added `test_gemini_initialization_with_env_var_api_key` and `test_vertexai_initialization_with_env_var_api_key`.
daavoo
added a commit
that referenced
this pull request
Sep 8, 2025
In #401 we stopped overriding `Provider.__init__` and thus we started to rely again on the default `Provider._verify_and_set_api_key`. We need to provide a custom implementation that checks for both API key options instead of the plain string with a `/`. - Added `test_gemini_initialization_with_env_var_api_key` and `test_vertexai_initialization_with_env_var_api_key`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We had the "google" provider grouping both gemini and vertex ai. This PR splits them into being separate providers
PR Type
🆕 New Feature 💅 Refactor ## Relevant issuesChecklist