fix(gemin): Implement _verify_and_set_api_key.
#410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #401 we stopped overriding `Provider.__init__` and thus we started to rely again on the default `Provider._verify_and_set_api_key`. We need to provide a custom implementation that checks for both API key options instead of the plain string with a `/`. - Added `test_gemini_initialization_with_env_var_api_key` and `test_vertexai_initialization_with_env_var_api_key`.
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 23 files with indirect coverage changes 🚀 New features to boost your workflow:
|
njbrake
previously approved these changes
Sep 8, 2025
Contributor
njbrake
left a comment
njbrake
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix 🙏
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #401 we stopped overriding
Provider.__init__and thus we started to rely again on the defaultProvider._verify_and_set_api_key.We need to provide a custom implementation that checks for both API key options instead of the plain string with a
/.test_gemini_initialization_with_env_var_api_keyandtest_vertexai_initialization_with_env_var_api_key.