Add --testcase-timeout CLI option #1241
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: butako <[email protected]>
Co-authored-by: butako <[email protected]>
Co-authored-by: butako <[email protected]>
Co-authored-by: butako <[email protected]>
Co-authored-by: butako <[email protected]>
Co-authored-by: butako <[email protected]>
Co-authored-by: butako <[email protected]>
…-31878d99c3ce Add --testcase-timeout CLI option to set default testcase timeout
Pyifan
reviewed
Nov 6, 2025
|
|
||
| time_restriction = getattr(testcase, "timeout", None) | ||
| # Use default testcase timeout from config if no explicit timeout is set | ||
| if time_restriction is None and self.cfg.testcase_timeout: |
Contributor
There was a problem hiding this comment.
The problem here is in our tests, multitest doesn't always have a parent, thus when timeout is not provided at multitest level, self.cfg.testcase_timeout could raise no such attr. We can use hasattr/getattr here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug / Requirement Description
Add --testcase-timeout option to allow user define a timeout globally when running the test_plan. This is useful to enforce
timeout in a large project with many tests.
Solution description
New CLI, ConfigOption and Testcase
Checklist: