Add --testcase-timeout CLI option to set default testcase timeout #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: butako <[email protected]>
Co-authored-by: butako <[email protected]>
Co-authored-by: butako <[email protected]>
Co-authored-by: butako <[email protected]>
Copilot
AI
changed the title
Testplan is a testing framework - read all about it in the repo docs. In particular read multitest -> testcase timeout. The testcase decorator accepts a timeout argument. I would like you to add a cli switch that when provided will set the default test...
Add --testcase-timeout CLI option to set default testcase timeout
Oct 3, 2025
Copilot finished work on behalf of
butako
October 3, 2025 21:04
butako
reviewed
Oct 4, 2025
| It's useful when ``setup`` has much initialization work that takes long, e.g. connects to a server but has no response and makes program hanging. Note that this ``@timeout`` decorator can also be used for ``pre_testcase`` and ``post_testcase``, but that is not suggested because pre/post testcase methods are called everytime before/after each testcase runs, they should be written as simple as possible. | ||
| Default Testcase Timeout |
Owner
There was a problem hiding this comment.
@copilot this documentation is too verbose, can you make it more succinct.
Author
There was a problem hiding this comment.
Made the documentation more succinct in commit b098c68. Reduced from ~15 lines to 7 lines while keeping all essential information.
Co-authored-by: butako <[email protected]>
Copilot finished work on behalf of
butako
October 4, 2025 20:05
butako
reviewed
Oct 4, 2025
| mockplan.add(multitest) | ||
| mockplan.run() | ||
|
|
||
| # First test should pass (completes quickly) |
Owner
There was a problem hiding this comment.
Correct terminology is 'testsuite' @copilot
Author
There was a problem hiding this comment.
Fixed terminology to use 'testsuite' in commit 94f645e.
Co-authored-by: butako <[email protected]>
Copilot finished work on behalf of
butako
October 4, 2025 20:12
butako
reviewed
Oct 14, 2025
Owner
There was a problem hiding this comment.
@copilot remove the example from the PR.
Co-authored-by: butako <[email protected]>
Copilot finished work on behalf of
butako
October 14, 2025 19:37
butako
approved these changes
Oct 14, 2025
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plan: Add --testcase-timeout CLI option
Summary
Successfully implemented the
--testcase-timeoutCLI option that allows setting a default timeout for all testcases in a Testplan.Changes Made:
TESTCASE_TIMEOUT = Nonedefault value--testcase-timeoutCLI argument with helpful descriptiontestcase_timeoutto TestRunnerConfig with validation allowing>= 0testcase_timeoutparameter to MultiTest.inittestcase_timeoutto MultiTestConfig options with validation allowing>= 0How it works:
python my_test.py --testcase-timeout 60MultiTest(name="test", suites=[...], testcase_timeout=60)--testcase-timeout 0disables the default timeout (equivalent to omitting the option)Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.