stable2412

[tmpolaczyk]

Upgrade polkadot-sdk to stable2412

main PRs

XCM v5

pallet identity migration - our first multiblock migration

extension weights - increases weight and proof size of all extrinsics by taking into account validations like signature, nonce, age, etc

CandidateReceiptV2

not important but good to know

extension weights - terminology change: unsigned => bare. Also refactors traits such as CreateSignedTransaction

deprecate RuntimeString - Remove sp_runtime::RuntimeString and replace with Cow<'static, str> or String depending on use case

system_version - rename RuntimeVersion::state_version to system_version. Setting system_version = 2 will make extrinsics use StateVersion::V1 instead of V0, but we don't do that, and neither does parity

remove ttl field - not removed, instead deprecated and ignored

new types in pallet config

cumulus core selector - type SelectCore

generic slashing side-effects - type DoneSlashHandler

pallet identity migration - type UsernameDeposit + type UsernameGracePeriod

pallet treasury generic BlockNumberProvider - type BlockNumberProvider

extension weights - type ExtensionsWeightInfo

Full PR list

#889

[github-actions]

WASM runtime size check:

Compared to target branch

dancebox runtime: 1500 KB (+72 KB) ⚠️

flashbox runtime: 888 KB (+40 KB) ⚠️

dancelight runtime: 2260 KB (+80 KB) ⚠️

container chain template simple runtime: 1176 KB (+44 KB) ⚠️

container chain template frontier runtime: 1452 KB (+36 KB) ⚠️

[github-actions]

Coverage Report

(master)

@@                    Coverage Diff                    @@
##           master   tomasz-wip-stable2412      +/-   ##
=========================================================
- Coverage   65.52%                  64.95%   -0.57%     
  Files         351                     351              
+ Lines       61264                   61855     +591     
=========================================================
+ Hits        40143                   40177      +34     
+ Misses      21121                   21678     +557     

Files Changed	Coverage
/chains/container-chains/nodes/frontier/src/service.rs	78.61% (-0.72%)	❗
/chains/container-chains/nodes/simple/src/service.rs	85.62% (-2.62%)	❗
/chains/container-chains/runtime-templates/frontier/src/lib.rs	57.92% (+0.22%)	✅
/chains/container-chains/runtime-templates/frontier/src/weights/xcm/mod.rs	14.49% (-1.90%)	❗
/chains/container-chains/runtime-templates/frontier/src/weights/xcm/pallet_xcm_benchmarks_generic.rs	15.09% (-1.50%)	❗
/chains/container-chains/runtime-templates/simple/src/lib.rs	81.33% (-5.94%)	❗
/chains/container-chains/runtime-templates/simple/src/weights/xcm/mod.rs	14.49% (-1.90%)	❗
/chains/container-chains/runtime-templates/simple/src/weights/xcm/pallet_xcm_benchmarks_generic.rs	9.05% (-0.90%)	❗
/chains/orchestrator-paras/node/src/service.rs	16.25% (+0.83%)	✅
/chains/orchestrator-paras/runtime/common/src/migrations.rs	78.52% (-7.40%)	❗
/chains/orchestrator-paras/runtime/dancebox/src/lib.rs	88.01% (+0.21%)	✅
/chains/orchestrator-paras/runtime/dancebox/src/tests/integration_test.rs	99.70% (-0.01%)	❗
/chains/orchestrator-paras/runtime/dancebox/src/weights/frame_system.rs	32.94% (+10.59%)	✅
/chains/orchestrator-paras/runtime/dancebox/src/weights/pallet_identity.rs	12.90% (-4.84%)	❗
/chains/orchestrator-paras/runtime/dancebox/src/weights/pallet_sudo.rs	19.05% (-4.48%)	❗
/chains/orchestrator-paras/runtime/dancebox/src/weights/xcm/mod.rs	38.16% (-5.01%)	❗
/chains/orchestrator-paras/runtime/dancebox/src/weights/xcm/pallet_xcm_benchmarks_generic.rs	40.09% (-3.99%)	❗
/chains/orchestrator-paras/runtime/flashbox/src/lib.rs	46.08% (+0.05%)	✅
/chains/orchestrator-relays/client/cli/src/cli.rs	41.18% (-2.57%)	❗
/chains/orchestrator-relays/client/cli/src/command.rs	48.36% (+0.68%)	✅
/chains/orchestrator-relays/node/tanssi-relay-service/src/dev_service.rs	91.74% (-0.16%)	❗
/chains/orchestrator-relays/runtime/dancelight/src/genesis_config_presets.rs	60.22% (+0.13%)	✅
/chains/orchestrator-relays/runtime/dancelight/src/lib.rs	68.66% (-0.42%)	❗
/chains/orchestrator-relays/runtime/dancelight/src/tests/common/mod.rs	92.86% (-4.69%)	❗
/chains/orchestrator-relays/runtime/dancelight/src/tests/migrations_test.rs	99.27% (+0.23%)	✅
/chains/orchestrator-relays/runtime/dancelight/src/weights/xcm/mod.rs	7.82% (-1.59%)	❗
/client/node-common/src/service.rs	47.51% (-0.22%)	❗
/pallets/author-noting/src/lib.rs	86.15% (+0.44%)	✅
/pallets/collator-assignment/src/lib.rs	98.47% (+0.26%)	✅
/pallets/configuration/src/lib.rs	86.74% (+0.31%)	✅
/pallets/data-preservers/src/lib.rs	85.66% (+0.36%)	✅
/pallets/inflation-rewards/src/lib.rs	91.11% (+0.74%)	✅
/pallets/invulnerables/src/lib.rs	88.68% (+0.94%)	✅
/pallets/ocw-testing/src/lib.rs	1.89% (-0.01%)	❗
/pallets/pooled-staking/src/candidate.rs	94.59% (+0.84%)	✅
/pallets/pooled-staking/src/lib.rs	57.45% (+2.28%)	✅
/pallets/registrar/src/lib.rs	88.08% (+0.14%)	✅
/pallets/services-payment/src/lib.rs	90.23% (+0.29%)	✅
/pallets/stream-payment/runtime-api/src/lib.rs	95.65% (-0.18%)	❗
/pallets/stream-payment/src/lib.rs	89.56% (+1.27%)	✅
/pallets/xcm-core-buyer/src/lib.rs	91.85% (+0.52%)	✅
/primitives/traits/src/lib.rs	65.22% (+2.28%)	✅

Coverage generated Wed Mar 5 14:03:22 UTC 2025

[girazoki]

Changes look good to me, my only comment is that we need to benchmark pallet_transaction_payment and also the new extensions. IF not in this PR, in another, but we should create an issue at least for this

[nanocryk]

LGTM outside of others comments

[Agusrodri]

LGTM. Great job @tmpolaczyk!