Update polkadot-sdk to stable2407

[tmpolaczyk]

Main changes:

NativeElseWasmExecutor has been deprecated, but we will keep using it for now. Removing it implies not being able to debug runtimes using breakpoints anymore.

cumulus-pallet-dmp-queue has been deprecated, it is safe to remove so we removed it. No need to kill pallet storage because it is automatically done in on_idle when migration completes.

pallet_treasury: proposeSpend and approveSpend have been removed. Instead of ApproveOrigin = Root and SpendOrigin = Never, we now have SpendOrigin = Root. In tests, users can no longer propose treasury spends, only root can spend. So I removed most of the treasury tests and added some new ones, please review that (test/suites/common-tanssi/pallet-treasury/test_pallet_treasury.ts). Info about the removal: paritytech/polkadot-sdk#138

Changed branch format in polkadot-sdk. Instead of "release-polkadot-v1.11.0", the release branch is now just called "stable2407". Our fork branch is called "tanssi-polkadot-stable2407" instead of "tanssi-polkadot-v1.11.0". I had to fix the download-polkadot.sh script, maybe other tools will break. More info:

https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-stable2407
https://github.com/paritytech/polkadot-sdk/blob/master/docs/RELEASE.md

[github-actions]

Coverage Report

(master)

@@                  Coverage Diff                   @@
##           master   upgrade-stable2407      +/-   ##
======================================================
+ Coverage   66.19%               66.49%   +0.30%     
- Files         264                  261       -3     
- Lines       45952                45854      -98     
======================================================
+ Hits        30414                30490      +76     
- Misses      15538                15364     -174     

Files Changed	Coverage
/client/node-common/src/service.rs	48.31% (+0.07%)	🔼
/container-chains/nodes/frontier/src/service.rs	79.57% (+0.07%)	🔼
/container-chains/nodes/simple/src/service.rs	86.52% (+0.09%)	🔼
/container-chains/runtime-templates/frontier/build.rs	100.00% (+100.00%)	🔼
/container-chains/runtime-templates/frontier/src/lib.rs	58.56% (-0.07%)	🔽
/container-chains/runtime-templates/simple/build.rs	100.00% (+100.00%)	🔼
/container-chains/runtime-templates/simple/src/lib.rs	87.23% (+15.85%)	🔼
/node/src/service.rs	23.62% (+0.15%)	🔼
/runtime/dancebox/build.rs	100.00% (+100.00%)	🔼
/runtime/dancebox/src/lib.rs	88.74% (-0.07%)	🔽
/runtime/dancebox/src/weights/pallet_balances.rs	18.18% (-3.51%)	🔽
/runtime/dancebox/src/weights/pallet_treasury.rs	26.47% (-3.43%)	🔽
/runtime/flashbox/build.rs	100.00% (+100.00%)	🔼
/solo-chains/runtime/starlight/build.rs	100.00% (+100.00%)	🔼
/solo-chains/runtime/starlight/src/lib.rs	24.67% (+0.04%)	🔼

Coverage generated Tue Aug 20 14:26:26 UTC 2024

[Agusrodri]

cumulus-pallet-dmp-queue has been deprecated, it is safe to remove so we removed it. TODO: need migration to kill storage?

We don't need an extra migration to kill storage of the dmp-queue pallet as the lazy migration present inside on_idle has been already completed.

If you check the chain state of the different networks (Dancebox, Flashbox), you will notice that the MigrationStatus storage returns Completed, and in that case the pallet can be safely removed.

• Deprecation note: https://github.com/paritytech/polkadot-sdk/blob/stable2407/cumulus/pallets/dmp-queue/src/lib.rs#L45
• Related PR: Use Message Queue as DMP and XCMP dispatch queue paritytech/polkadot-sdk#1246

[Agusrodri]

The overall changes (specially the treasury ones and related TS tests) look good to me.

[tmpolaczyk]

We don't need an extra migration to kill storage of the dmp-queue pallet as the lazy migration present inside on_idle has been already completed.

Ok that's very smart, thanks for checking @Agusrodri

[girazoki]

LGTM!