Update polkadot-sdk to stable2407 (#648)

Author: tmpolaczyk

Cargo.lock

@@ -33,6 +33,7 @@ sp-runtime = { workspace = true }
 sp-state-machine = { workspace = true }
 sp-timestamp = { workspace = true }
 sp-transaction-pool = { workspace = true }
+sp-version = { workspace = true }
 substrate-prometheus-endpoint = { workspace = true }
 
 # Own

Cargo.toml

@@ -26,7 +26,10 @@ use {
     async_trait::async_trait,
     cumulus_client_collator::service::CollatorService,
     cumulus_client_consensus_proposer::Proposer as ConsensusProposer,
-    cumulus_primitives_core::{relay_chain::BlockId, CollationInfo, CollectCollationInfo, ParaId},
+    cumulus_primitives_core::{
+        relay_chain::{BlockId, BlockNumber, CoreState},
+        CollationInfo, CollectCollationInfo, ParaId,
+    },
     cumulus_relay_chain_interface::{
         CommittedCandidateReceipt, OverseerHandle, RelayChainInterface, RelayChainResult,
         StorageValue,
@@ -64,6 +67,7 @@ use {
         Digest, DigestItem,
     },
     sp_timestamp::Timestamp,
+    sp_version::RuntimeVersion,
     std::{
         collections::{BTreeMap, BTreeSet},
         pin::Pin,
@@ -259,6 +263,25 @@ impl RelayChainInterface for RelayChain {
     ) -> RelayChainResult<Option<polkadot_primitives::ValidationCodeHash>> {
         unimplemented!("Not needed for test")
     }
+
+    async fn candidates_pending_availability(
+        &self,
+        _: PHash,
+        _: ParaId,
+    ) -> RelayChainResult<Vec<CommittedCandidateReceipt>> {
+        unimplemented!("Not needed for test")
+    }
+
+    async fn availability_cores(
+        &self,
+        _relay_parent: PHash,
+    ) -> RelayChainResult<Vec<CoreState<PHash, BlockNumber>>> {
+        unimplemented!("Not needed for test");
+    }
+
+    async fn version(&self, _: PHash) -> RelayChainResult<RuntimeVersion> {
+        unimplemented!("Not needed for test")
+    }
 }
 
 #[derive(Clone)]
@@ -303,7 +326,7 @@ impl SealExtractorVerfier {
 #[async_trait::async_trait]
 impl<B: BlockT> sc_consensus::Verifier<B> for SealExtractorVerfier {
     async fn verify(
-        &mut self,
+        &self,
         mut block: sc_consensus::BlockImportParams<B>,
     ) -> Result<sc_consensus::BlockImportParams<B>, String> {
         if block.fork_choice.is_none() {

client/consensus/Cargo.toml

@@ -37,8 +37,8 @@ use {
     },
     sc_executor::{
         sp_wasm_interface::{ExtendedHostFunctions, HostFunctions},
-        HeapAllocStrategy, NativeElseWasmExecutor, NativeExecutionDispatch, RuntimeVersionOf,
-        WasmExecutor, DEFAULT_HEAP_ALLOC_STRATEGY,
+        HeapAllocStrategy, NativeExecutionDispatch, RuntimeVersionOf, WasmExecutor,
+        DEFAULT_HEAP_ALLOC_STRATEGY,
     },
     sc_network::{config::FullNetworkConfiguration, NetworkBlock},
     sc_network_sync::SyncingService,
@@ -62,6 +62,9 @@ use {
     std::{str::FromStr, sync::Arc},
 };
 
+#[allow(deprecated)]
+use sc_executor::NativeElseWasmExecutor;
+
 /// Trait to configure the main types the builder rely on, bundled in a single
 /// type to reduce verbosity and the amount of type parameters.
 pub trait NodeBuilderConfig {
@@ -174,13 +177,15 @@ impl TanssiExecutorExt for WasmExecutor<ParachainHostFunctions> {
     }
 }
 
+#[allow(deprecated)]
 impl<D> TanssiExecutorExt for NativeElseWasmExecutor<D>
 where
     D: NativeExecutionDispatch,
 {
     type HostFun = ExtendedHostFunctions<sp_io::SubstrateHostFunctions, D::ExtendHostFunctions>;
 
     fn new_with_wasm_executor(wasm_executor: WasmExecutor<Self::HostFun>) -> Self {
+        #[allow(deprecated)]
         NativeElseWasmExecutor::new_with_wasm_executor(wasm_executor)
     }
 }

client/consensus/src/tests.rs

@@ -21,7 +21,7 @@ use {
 };
 
 /// Specialized `ChainSpec` for container chains that only allows raw genesis format.
-pub type RawChainSpec = sc_service::GenericChainSpec<RawGenesisConfig, Extensions>;
+pub type RawChainSpec = sc_service::GenericChainSpec<Extensions>;
 
 /// Helper type that implements the traits needed to be used as a "GenesisConfig",
 /// but whose implementation panics because we only expect it to be used with raw ChainSpecs,

client/node-common/src/service.rs

@@ -35,7 +35,7 @@ use {
     polkadot_primitives::CollatorPair,
     sc_basic_authorship::ProposerFactory,
     sc_consensus::{BasicQueue, BlockImport},
-    sc_executor::{NativeElseWasmExecutor, WasmExecutor},
+    sc_executor::WasmExecutor,
     sc_network::NetworkBlock,
     sc_network_sync::SyncingService,
     sc_service::{
@@ -58,6 +58,9 @@ use {
     tokio_util::sync::CancellationToken,
 };
 
+#[allow(deprecated)]
+use sc_executor::NativeElseWasmExecutor;
+
 type FullBackend = TFullBackend<Block>;
 
 /// Native executor type.
@@ -102,12 +105,12 @@ impl<BI> OrchestratorParachainBlockImport<BI> {
 #[async_trait::async_trait]
 impl<BI> BlockImport<Block> for OrchestratorParachainBlockImport<BI>
 where
-    BI: BlockImport<Block> + Send,
+    BI: BlockImport<Block> + Send + Sync,
 {
     type Error = BI::Error;
 
     async fn check_block(
-        &mut self,
+        &self,
         block: sc_consensus::BlockCheckParams<Block>,
     ) -> Result<sc_consensus::ImportResult, Self::Error> {
         self.inner.check_block(block).await
@@ -127,6 +130,7 @@ where
 impl<BI> ParachainBlockImportMarker for OrchestratorParachainBlockImport<BI> {}
 
 // Orchestrator chain types
+#[allow(deprecated)]
 pub type ParachainExecutor = NativeElseWasmExecutor<ParachainNativeExecutor>;
 pub type ParachainClient = TFullClient<Block, RuntimeApi, ParachainExecutor>;
 pub type ParachainBackend = TFullBackend<Block>;

client/service-container-chain/src/chain_spec.rs

@@ -29,10 +29,7 @@ use {
 };
 
 /// Specialized `ChainSpec` for the normal parachain runtime.
-pub type ChainSpec = sc_service::GenericChainSpec<
-    container_chain_template_frontier_runtime::RuntimeGenesisConfig,
-    Extensions,
->;
+pub type ChainSpec = sc_service::GenericChainSpec<Extensions>;
 
 /// Orcherstrator's parachain id
 pub const ORCHESTRATOR: ParaId = ParaId::new(1000);

client/service-container-chain/src/service.rs

@@ -438,6 +438,7 @@ pub async fn start_dev_node(
                     let time = MockTimestampInherentDataProvider;
                     let mocked_parachain = MockValidationDataInherentDataProvider {
                         current_para_block,
+                        current_para_block_head: None,
                         relay_offset: 1000,
                         relay_blocks_per_para_block: 2,
                         // TODO: Recheck
@@ -446,12 +447,12 @@ pub async fn start_dev_node(
                         xcm_config: MockXcmConfig::new(
                             &*client_for_xcm,
                             block,
-                            para_id,
                             Default::default(),
                         ),
                         raw_downward_messages: downward_xcm_receiver.drain().collect(),
                         raw_horizontal_messages: hrmp_xcm_receiver.drain().collect(),
                         additional_key_values: Some(additional_keys),
+                        para_id,
                     };
 
                     Ok((time, mocked_parachain, mocked_authorities_noting))

container-chains/nodes/frontier/src/chain_spec.rs

@@ -28,10 +28,7 @@ use {
 };
 
 /// Specialized `ChainSpec` for the normal parachain runtime.
-pub type ChainSpec = sc_service::GenericChainSpec<
-    container_chain_template_simple_runtime::RuntimeGenesisConfig,
-    Extensions,
->;
+pub type ChainSpec = sc_service::GenericChainSpec<Extensions>;
 
 /// Helper function to generate a crypto pair from seed
 pub fn get_from_seed<TPublic: Public>(seed: &str) -> <TPublic::Pair as Pair>::Public {