Skip to content

Pass signature as &[u8] to avoid triggering From::from conversion #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
girazoki merged 2 commits into from
Nov 1, 2022
Merged

Pass signature as &[u8] to avoid triggering From::from conversion #47

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
edac5f5
pass signature as ref to avoid From::from conversion
nbaztec Nov 1, 2022
4adb308
comment on bug
girazoki Nov 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions primitives/io/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -755,8 +755,11 @@ pub trait Crypto {
return false
};

let sig =
if let Ok(s) = ed25519_dalek::Signature::try_from(sig.0) { s } else { return false };
let sig = if let Ok(s) = ed25519_dalek::Signature::try_from(sig.0.as_ref()) {
s
} else {
return false
};

public_key.verify(msg, &sig).is_ok()
}
Expand Down