Pass signature as &[u8] to avoid triggering From::from conversion#47
Merged
girazoki merged 2 commits intomoonbeam-polkadot-v0.9.29from Nov 1, 2022
Merged
Pass signature as &[u8] to avoid triggering From::from conversion#47girazoki merged 2 commits intomoonbeam-polkadot-v0.9.29from
girazoki merged 2 commits intomoonbeam-polkadot-v0.9.29from
Conversation
girazoki
approved these changes
Nov 1, 2022
notlesh
approved these changes
Nov 1, 2022
notlesh
left a comment
notlesh
left a comment
There was a problem hiding this comment.
LGTM. A comment about this subtle issue would help
|
Added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a behavior bug introduced in ec0de09 where the signature was being passed as
[u8; 64]triggering aFrom::fromconversion https://github.com/RustCrypto/signatures/blob/d610ad50d3f7dac0bad9e647231bf03aabab3078/ed25519/src/lib.rs#L372 as the impl is also auto-implemented forTryFrom.Related issue RustCrypto/signatures#563