Add pallet_parameters (moonbase only) by TarekkMA · Pull Request #2923 · moonbeam-foundation/moonbeam

TarekkMA · 2024-08-30T12:07:17Z

OLD PR: #2898 (Changed the branch to be on moonbeam repo)

What does it do?

Add pallet_parameters to allow setting constants using a root origin.

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

Pallet parameters account for all parameters read weight polkadot-sdk#8

What value does it bring to the blockchain users?

Co-authored-by: Rodrigo Quelhas <22591718+RomarQ@users.noreply.github.com>

…arameters

github-actions · 2024-08-30T12:23:04Z

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2180 KB (no changes) ✅

Moonbeam runtime: 2120 KB (no changes) ✅

Moonriver runtime: 2120 KB (no changes) ✅

Compared to latest release (runtime-3100)

Moonbase runtime: 2180 KB (+164 KB compared to latest release) ⚠️

Moonbeam runtime: 2120 KB (+144 KB compared to latest release) ⚠️

Moonriver runtime: 2120 KB (+152 KB compared to latest release) ⚠️

github-actions · 2024-08-30T12:49:42Z

Coverage Report

@@                      Coverage Diff                       @@
##           master   tarekkma/pallet-parameters      +/-   ##
==============================================================
- Coverage   80.93%                       80.91%   -0.02%     
+ Files         284                          286       +2     
+ Lines       81724                        81749      +25     
==============================================================
+ Hits        66136                        66142       +6     
+ Misses      15588                        15607      +19

Files Changed	Coverage
/runtime/common/src/apis.rs	28.23% (-0.17%)	🔽
/runtime/moonbase/src/lib.rs	52.93% (+0.22%)	🔼

Coverage generated Fri Aug 30 12:49:32 UTC 2024

* add pallet parameters * XcmFeesAccount * add copyrights * add FeesTreasuryProportion --------- Co-authored-by: Rodrigo Quelhas <22591718+RomarQ@users.noreply.github.com>

* point dependencies to moonbeam-polkadot-sdk-stable2407 * bump packages versions to match polkadot-sdk * apply TransactionPov changes * update runtime configs (wip) * update imports * mute hrmp channel moonriver - Litmus (#2914) * Add step to Build workflow to check for WASM runtime sizes (#2888) * add simple wasm size check * only run on pull requests * add Github token to env * fix download dir name * try comparing previous and current runtimes * change master branch with dynamic target branch ref * add comparison to latest release * test with older release * download from release instead of workflow artifact * debug release tag not saved to env * debug some more * use gh cli to get releases instead of git tag * use gh api instead of releases * remove get build id & fix awk parsing * build runtimes with _, releases with - * add comment to PR and format msg * use markdown report & replace comment * cat report & fix comment formatting * add twiggy diff reports as artifacts * use upload v4 & create reports dir * rm: deprecated ::set-output cmd * add log event (#2918) * Extract Storage Read costs for dev tests involved in #2786 (#2915) * add: storage read cost constant * update test-pov * update xcm-v3 tests * update xcm-v4 tests * add storage read gas cost to constants * update test-precompile * load constant in beforeAll * replace gas cost with weight to gas ratio * Fix auto-pause xcm: incoming XCMP messages where dropped when auto-pause (#2913) * chore: rename crate manual-xcm-rpc -> moonbeam-dev-rpc * add RPC method test_skipRelayBlocks * allow Root to resume XCM execution * update moonkit pin * add dev-test that trigger auto-pause of xcm * prettier * dev test auto-pause xcm: remove unused imports & improve test scenario * add pallet-emergency-para-xcm to moonriver * add pallet-emergency-para-xcm to moonbeam * apply review suggestions * Set the block size to 60mln gas for moonbeam (#2921) * set the block size to 60mln gas for moonbeam * update mbip-5 value in test * Add pallet_parameters (moonbase only) (#2923) * add pallet parameters * XcmFeesAccount * add copyrights * add FeesTreasuryProportion --------- Co-authored-by: Rodrigo Quelhas <22591718+RomarQ@users.noreply.github.com> * make moonbeam compile * remove cumulus_pallet_dmp_queue * remove unused import * add proper para_id to MockValidationDataInherentDataProvider * update config for tests * add MockTimestampInherentDataProvider to simulate consistent and sequential relay slots * Revert "apply TransactionPov changes" This reverts commit 4382107. * update cargo lock pins * remove import of deleted TransacionPoV * Make cargo test compile * Add XcmRecorder to XcmConfig * Add VersionWrapper to hrmp::COnfig * Remove code from deprecated pallet treasury * Remove code from deprecated DmpQueue * Remove code from deprecated XCMV2 * remove deprecated tresury pallet tests, add some for the new functionality * fix tests * fix remaining dev tests * fix licenses * fix lazy loading backend for stable * remove unused patch * fix linters * fix cargo test with benchmarking and tracing enabled * fix lazy loading * fix command for lazy loading * update frontier pin * support new 'stableYYMM' versioning for polkadot * update polkadot sdk pin * fix download-polkadot script * simplify script * Replace thread_local with AtomicU64 (as per review request) * remove deprecated test code * use latest version of nextest * Update precompiles/collective/src/mock.rs Co-authored-by: Rodrigo Quelhas <22591718+RomarQ@users.noreply.github.com> * apply review suggestions * Revert "apply review suggestions" This reverts commit 6daef57. * apply review suggestions * fix lazy-loading * re add reset_issuance * add missing weights * remove unused var * fix download correct binaries * cargo fmt * make polkadot worker binearies executable * configure XcmRecorder for mocks --------- Co-authored-by: Éloïs <c@elo.tf> Co-authored-by: pablito テ <pablitolabarta@gmail.com> Co-authored-by: Rodrigo Quelhas <22591718+RomarQ@users.noreply.github.com> Co-authored-by: Andrea Giacobino <no.andrea@gmail.com> Co-authored-by: Tarek Mohamed Abdalla <tarekkma@gmail.com> Co-authored-by: Rodrigo Quelhas <rodrigo_quelhas@outlook.pt> Co-authored-by: Agusrodri <agusrodriguez2456@gmail.com>

…#2980) * point dependencies to moonbeam-polkadot-sdk-stable2407 * bump packages versions to match polkadot-sdk * apply TransactionPov changes * update runtime configs (wip) * update imports * mute hrmp channel moonriver - Litmus (#2914) * Add step to Build workflow to check for WASM runtime sizes (#2888) * add simple wasm size check * only run on pull requests * add Github token to env * fix download dir name * try comparing previous and current runtimes * change master branch with dynamic target branch ref * add comparison to latest release * test with older release * download from release instead of workflow artifact * debug release tag not saved to env * debug some more * use gh cli to get releases instead of git tag * use gh api instead of releases * remove get build id & fix awk parsing * build runtimes with _, releases with - * add comment to PR and format msg * use markdown report & replace comment * cat report & fix comment formatting * add twiggy diff reports as artifacts * use upload v4 & create reports dir * rm: deprecated ::set-output cmd * add log event (#2918) * Extract Storage Read costs for dev tests involved in #2786 (#2915) * add: storage read cost constant * update test-pov * update xcm-v3 tests * update xcm-v4 tests * add storage read gas cost to constants * update test-precompile * load constant in beforeAll * replace gas cost with weight to gas ratio * Fix auto-pause xcm: incoming XCMP messages where dropped when auto-pause (#2913) * chore: rename crate manual-xcm-rpc -> moonbeam-dev-rpc * add RPC method test_skipRelayBlocks * allow Root to resume XCM execution * update moonkit pin * add dev-test that trigger auto-pause of xcm * prettier * dev test auto-pause xcm: remove unused imports & improve test scenario * add pallet-emergency-para-xcm to moonriver * add pallet-emergency-para-xcm to moonbeam * apply review suggestions * Set the block size to 60mln gas for moonbeam (#2921) * set the block size to 60mln gas for moonbeam * update mbip-5 value in test * Add pallet_parameters (moonbase only) (#2923) * add pallet parameters * XcmFeesAccount * add copyrights * add FeesTreasuryProportion --------- Co-authored-by: Rodrigo Quelhas <22591718+RomarQ@users.noreply.github.com> * make moonbeam compile * remove cumulus_pallet_dmp_queue * remove unused import * add proper para_id to MockValidationDataInherentDataProvider * update config for tests * add MockTimestampInherentDataProvider to simulate consistent and sequential relay slots * Revert "apply TransactionPov changes" This reverts commit 4382107. * update cargo lock pins * remove import of deleted TransacionPoV * Make cargo test compile * Add XcmRecorder to XcmConfig * Add VersionWrapper to hrmp::COnfig * Remove code from deprecated pallet treasury * Remove code from deprecated DmpQueue * Remove code from deprecated XCMV2 * remove deprecated tresury pallet tests, add some for the new functionality * fix tests * fix remaining dev tests * fix licenses * fix lazy loading backend for stable * remove unused patch * fix linters * fix cargo test with benchmarking and tracing enabled * fix lazy loading * fix command for lazy loading * update frontier pin * support new 'stableYYMM' versioning for polkadot * update polkadot sdk pin * fix download-polkadot script * simplify script * Replace thread_local with AtomicU64 (as per review request) * remove deprecated test code * use latest version of nextest * add DryRunApi and LocationToAccountApi * Update precompiles/collective/src/mock.rs Co-authored-by: Rodrigo Quelhas <22591718+RomarQ@users.noreply.github.com> * apply review suggestions * Revert "apply review suggestions" This reverts commit 6daef57. * apply review suggestions * fix lazy-loading * re add reset_issuance * add missing weights * remove unused var * add TS tests * cleanup * fmt * fix download correct binaries * cargo fmt * make polkadot worker binearies executable * configure XcmRecorder for mocks --------- Co-authored-by: Gonza Montiel <gon.montiel@gmail.com> Co-authored-by: Éloïs <c@elo.tf> Co-authored-by: pablito テ <pablitolabarta@gmail.com> Co-authored-by: Rodrigo Quelhas <22591718+RomarQ@users.noreply.github.com> Co-authored-by: Andrea Giacobino <no.andrea@gmail.com> Co-authored-by: Tarek Mohamed Abdalla <tarekkma@gmail.com> Co-authored-by: Rodrigo Quelhas <rodrigo_quelhas@outlook.pt> Co-authored-by: Gonza Montiel <gonzamontiel@users.noreply.github.com>

TarekkMA and others added 27 commits August 5, 2024 10:33

pallet parameters

8284977

add pallet parameters

2f2ae0b

remove unused import

795609e

XcmFeesAccount

3926815

Update runtime/moonbase/src/lib.rs

c7c54d2

Co-authored-by: Rodrigo Quelhas <22591718+RomarQ@users.noreply.github.com>

format

806312a

Merge branch 'master' into tarekkma/pallet-parameters

fb6e675

fix

30ef82d

fix

116732a

fix

bb95d28

fix

e4cb2b8

add copyrights

921b1dc

fix copyright

081701b

testing

e296721

remove unused

a4546e0

format

150e816

add FeesTreasuryPercentage

d731b40

fmt

b276f54

revert

8b498d4

fix

8e7c049

fix

68bb6cc

rename to FeesTreasuryProportion

77e2ee7

Merge branch 'master' into tarekkma/pallet-parameters

c72509d

fix the white list

efd1804

Merge remote-tracking branch 'upstream/master' into tarekkma/pallet-p…

2dd13d9

…arameters

fix line

26b7e7c

fmt

f6ca687

TarekkMA mentioned this pull request Aug 30, 2024

Add pallet_parameters. #2898

Closed

TarekkMA added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Aug 30, 2024

TarekkMA added the breaking Needs to be mentioned in breaking changes label Aug 30, 2024

librelois approved these changes Aug 30, 2024

View reviewed changes

librelois changed the title ~~Add pallet_parameters.~~ Add pallet_parameters (moonbase only) Aug 30, 2024

RomarQ approved these changes Aug 30, 2024

View reviewed changes

RomarQ merged commit ca05e28 into master Aug 30, 2024

RomarQ deleted the tarekkma/pallet-parameters branch August 30, 2024 17:38

TarekkMA mentioned this pull request Nov 12, 2024

Apply FeesTreasuryProportion to Substate-based txs tips and Ethereum-based transactions fees. #3043

Merged

TarekkMA mentioned this pull request Dec 27, 2024

Send priority fees to collators #3120

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add pallet_parameters (moonbase only)#2923

Add pallet_parameters (moonbase only)#2923
RomarQ merged 27 commits intomasterfrom
tarekkma/pallet-parameters

TarekkMA commented Aug 30, 2024

Uh oh!

github-actions bot commented Aug 30, 2024

Uh oh!

github-actions bot commented Aug 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

TarekkMA commented Aug 30, 2024

What does it do?

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

Uh oh!

github-actions bot commented Aug 30, 2024

WASM runtime size check:

Compared to target branch

Compared to latest release (runtime-3100)

Uh oh!

github-actions bot commented Aug 30, 2024

Coverage Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants