Add `evm::tracing::Event::Log` event by RomarQ · Pull Request #2918 · moonbeam-foundation/moonbeam

RomarQ · 2024-08-28T18:43:25Z

What does it do?

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

github-actions · 2024-08-28T19:08:58Z

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2168 KB (no changes) ✅

Moonbeam runtime: 2116 KB (no changes) ✅

Moonriver runtime: 2116 KB (no changes) ✅

Compared to latest release (runtime-3100)

Moonbase runtime: 2168 KB (+152 KB compared to latest release) ⚠️

Moonbeam runtime: 2116 KB (+140 KB compared to latest release) ⚠️

Moonriver runtime: 2116 KB (+148 KB compared to latest release) ⚠️

github-actions · 2024-08-28T19:53:22Z

Coverage Report

@@                  Coverage Diff                  @@
##           master   rq/evm-tracing-log     +/-   ##
=====================================================
  Coverage   80.93%               80.93%   0.00%     
  Files         284                  284             
+ Lines       81715                81724      +9     
=====================================================
  Hits        66136                66136             
+ Misses      15579                15588      +9

Files Changed	Coverage

Coverage generated Wed Aug 28 19:53:11 UTC 2024

* point dependencies to moonbeam-polkadot-sdk-stable2407 * bump packages versions to match polkadot-sdk * apply TransactionPov changes * update runtime configs (wip) * update imports * mute hrmp channel moonriver - Litmus (#2914) * Add step to Build workflow to check for WASM runtime sizes (#2888) * add simple wasm size check * only run on pull requests * add Github token to env * fix download dir name * try comparing previous and current runtimes * change master branch with dynamic target branch ref * add comparison to latest release * test with older release * download from release instead of workflow artifact * debug release tag not saved to env * debug some more * use gh cli to get releases instead of git tag * use gh api instead of releases * remove get build id & fix awk parsing * build runtimes with _, releases with - * add comment to PR and format msg * use markdown report & replace comment * cat report & fix comment formatting * add twiggy diff reports as artifacts * use upload v4 & create reports dir * rm: deprecated ::set-output cmd * add log event (#2918) * Extract Storage Read costs for dev tests involved in #2786 (#2915) * add: storage read cost constant * update test-pov * update xcm-v3 tests * update xcm-v4 tests * add storage read gas cost to constants * update test-precompile * load constant in beforeAll * replace gas cost with weight to gas ratio * Fix auto-pause xcm: incoming XCMP messages where dropped when auto-pause (#2913) * chore: rename crate manual-xcm-rpc -> moonbeam-dev-rpc * add RPC method test_skipRelayBlocks * allow Root to resume XCM execution * update moonkit pin * add dev-test that trigger auto-pause of xcm * prettier * dev test auto-pause xcm: remove unused imports & improve test scenario * add pallet-emergency-para-xcm to moonriver * add pallet-emergency-para-xcm to moonbeam * apply review suggestions * Set the block size to 60mln gas for moonbeam (#2921) * set the block size to 60mln gas for moonbeam * update mbip-5 value in test * Add pallet_parameters (moonbase only) (#2923) * add pallet parameters * XcmFeesAccount * add copyrights * add FeesTreasuryProportion --------- Co-authored-by: Rodrigo Quelhas <22591718+RomarQ@users.noreply.github.com> * make moonbeam compile * remove cumulus_pallet_dmp_queue * remove unused import * add proper para_id to MockValidationDataInherentDataProvider * update config for tests * add MockTimestampInherentDataProvider to simulate consistent and sequential relay slots * Revert "apply TransactionPov changes" This reverts commit 4382107. * update cargo lock pins * remove import of deleted TransacionPoV * Make cargo test compile * Add XcmRecorder to XcmConfig * Add VersionWrapper to hrmp::COnfig * Remove code from deprecated pallet treasury * Remove code from deprecated DmpQueue * Remove code from deprecated XCMV2 * remove deprecated tresury pallet tests, add some for the new functionality * fix tests * fix remaining dev tests * fix licenses * fix lazy loading backend for stable * remove unused patch * fix linters * fix cargo test with benchmarking and tracing enabled * fix lazy loading * fix command for lazy loading * update frontier pin * support new 'stableYYMM' versioning for polkadot * update polkadot sdk pin * fix download-polkadot script * simplify script * Replace thread_local with AtomicU64 (as per review request) * remove deprecated test code * use latest version of nextest * Update precompiles/collective/src/mock.rs Co-authored-by: Rodrigo Quelhas <22591718+RomarQ@users.noreply.github.com> * apply review suggestions * Revert "apply review suggestions" This reverts commit 6daef57. * apply review suggestions * fix lazy-loading * re add reset_issuance * add missing weights * remove unused var * fix download correct binaries * cargo fmt * make polkadot worker binearies executable * configure XcmRecorder for mocks --------- Co-authored-by: Éloïs <c@elo.tf> Co-authored-by: pablito テ <pablitolabarta@gmail.com> Co-authored-by: Rodrigo Quelhas <22591718+RomarQ@users.noreply.github.com> Co-authored-by: Andrea Giacobino <no.andrea@gmail.com> Co-authored-by: Tarek Mohamed Abdalla <tarekkma@gmail.com> Co-authored-by: Rodrigo Quelhas <rodrigo_quelhas@outlook.pt> Co-authored-by: Agusrodri <agusrodriguez2456@gmail.com>

…#2980) * point dependencies to moonbeam-polkadot-sdk-stable2407 * bump packages versions to match polkadot-sdk * apply TransactionPov changes * update runtime configs (wip) * update imports * mute hrmp channel moonriver - Litmus (#2914) * Add step to Build workflow to check for WASM runtime sizes (#2888) * add simple wasm size check * only run on pull requests * add Github token to env * fix download dir name * try comparing previous and current runtimes * change master branch with dynamic target branch ref * add comparison to latest release * test with older release * download from release instead of workflow artifact * debug release tag not saved to env * debug some more * use gh cli to get releases instead of git tag * use gh api instead of releases * remove get build id & fix awk parsing * build runtimes with _, releases with - * add comment to PR and format msg * use markdown report & replace comment * cat report & fix comment formatting * add twiggy diff reports as artifacts * use upload v4 & create reports dir * rm: deprecated ::set-output cmd * add log event (#2918) * Extract Storage Read costs for dev tests involved in #2786 (#2915) * add: storage read cost constant * update test-pov * update xcm-v3 tests * update xcm-v4 tests * add storage read gas cost to constants * update test-precompile * load constant in beforeAll * replace gas cost with weight to gas ratio * Fix auto-pause xcm: incoming XCMP messages where dropped when auto-pause (#2913) * chore: rename crate manual-xcm-rpc -> moonbeam-dev-rpc * add RPC method test_skipRelayBlocks * allow Root to resume XCM execution * update moonkit pin * add dev-test that trigger auto-pause of xcm * prettier * dev test auto-pause xcm: remove unused imports & improve test scenario * add pallet-emergency-para-xcm to moonriver * add pallet-emergency-para-xcm to moonbeam * apply review suggestions * Set the block size to 60mln gas for moonbeam (#2921) * set the block size to 60mln gas for moonbeam * update mbip-5 value in test * Add pallet_parameters (moonbase only) (#2923) * add pallet parameters * XcmFeesAccount * add copyrights * add FeesTreasuryProportion --------- Co-authored-by: Rodrigo Quelhas <22591718+RomarQ@users.noreply.github.com> * make moonbeam compile * remove cumulus_pallet_dmp_queue * remove unused import * add proper para_id to MockValidationDataInherentDataProvider * update config for tests * add MockTimestampInherentDataProvider to simulate consistent and sequential relay slots * Revert "apply TransactionPov changes" This reverts commit 4382107. * update cargo lock pins * remove import of deleted TransacionPoV * Make cargo test compile * Add XcmRecorder to XcmConfig * Add VersionWrapper to hrmp::COnfig * Remove code from deprecated pallet treasury * Remove code from deprecated DmpQueue * Remove code from deprecated XCMV2 * remove deprecated tresury pallet tests, add some for the new functionality * fix tests * fix remaining dev tests * fix licenses * fix lazy loading backend for stable * remove unused patch * fix linters * fix cargo test with benchmarking and tracing enabled * fix lazy loading * fix command for lazy loading * update frontier pin * support new 'stableYYMM' versioning for polkadot * update polkadot sdk pin * fix download-polkadot script * simplify script * Replace thread_local with AtomicU64 (as per review request) * remove deprecated test code * use latest version of nextest * add DryRunApi and LocationToAccountApi * Update precompiles/collective/src/mock.rs Co-authored-by: Rodrigo Quelhas <22591718+RomarQ@users.noreply.github.com> * apply review suggestions * Revert "apply review suggestions" This reverts commit 6daef57. * apply review suggestions * fix lazy-loading * re add reset_issuance * add missing weights * remove unused var * add TS tests * cleanup * fmt * fix download correct binaries * cargo fmt * make polkadot worker binearies executable * configure XcmRecorder for mocks --------- Co-authored-by: Gonza Montiel <gon.montiel@gmail.com> Co-authored-by: Éloïs <c@elo.tf> Co-authored-by: pablito テ <pablitolabarta@gmail.com> Co-authored-by: Rodrigo Quelhas <22591718+RomarQ@users.noreply.github.com> Co-authored-by: Andrea Giacobino <no.andrea@gmail.com> Co-authored-by: Tarek Mohamed Abdalla <tarekkma@gmail.com> Co-authored-by: Rodrigo Quelhas <rodrigo_quelhas@outlook.pt> Co-authored-by: Gonza Montiel <gonzamontiel@users.noreply.github.com>

add log event

bb730e5

RomarQ requested a review from pLabarta August 28, 2024 18:43

librelois approved these changes Aug 28, 2024

View reviewed changes

pLabarta approved these changes Aug 28, 2024

View reviewed changes

RomarQ merged commit e7cec54 into master Aug 28, 2024

RomarQ deleted the rq/evm-tracing-log branch August 28, 2024 19:56

gonzamontiel pushed a commit that referenced this pull request Sep 4, 2024

add log event (#2918)

22541c9

dnjscksdn98 added a commit to bifrost-platform/bifrost-frontier that referenced this pull request Jul 25, 2025

Add evm::tracing::Event::Log event #moonbeam-foundation/moonbeam#2918

9112e8d

dnjscksdn98 added a commit to bifrost-platform/bifrost-frontier that referenced this pull request Jul 28, 2025

Add evm::tracing::Event::Log event #moonbeam-foundation/moonbeam#2918

6301e17

alstjd0921 pushed a commit to bifrost-platform/bifrost-frontier that referenced this pull request Aug 14, 2025

Add evm::tracing::Event::Log event #moonbeam-foundation/moonbeam#2918

c07397b

dnjscksdn98 added a commit to bifrost-platform/bifrost-frontier that referenced this pull request Sep 15, 2025

Add evm::tracing::Event::Log event #moonbeam-foundation/moonbeam#2918

537dbd1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `evm::tracing::Event::Log` event#2918

Add `evm::tracing::Event::Log` event#2918
RomarQ merged 1 commit intomasterfrom
rq/evm-tracing-log

RomarQ commented Aug 28, 2024

Uh oh!

github-actions bot commented Aug 28, 2024

Uh oh!

github-actions bot commented Aug 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

RomarQ commented Aug 28, 2024

What does it do?

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

Uh oh!

github-actions bot commented Aug 28, 2024

WASM runtime size check:

Compared to target branch

Compared to latest release (runtime-3100)

Uh oh!

github-actions bot commented Aug 28, 2024

Coverage Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants