Skip to content

fix incorrect eth parent hashes on moonbase#2524

Merged
nbaztec merged 3 commits intomasterfrom
nish-fix-parent-hash
Oct 17, 2023
Merged

fix incorrect eth parent hashes on moonbase#2524
nbaztec merged 3 commits intomasterfrom
nish-fix-parent-hash

Conversation

@nbaztec
Copy link
Copy Markdown
Contributor

@nbaztec nbaztec commented Oct 16, 2023

What does it do?

Fixes incorrect eth parent hash for the block 1648995 on moonbase that is retrieving via RPC. No other blocks were found with the same issue.

What important points reviewers should know?

This isn't being applied for --dev mode.

See context:

@nbaztec nbaztec added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit breaking Needs to be mentioned in breaking changes labels Oct 16, 2023
@nbaztec nbaztec changed the title fix incorrect parent hashes fix incorrect parent hashes on moonbase Oct 16, 2023
@nbaztec nbaztec changed the title fix incorrect parent hashes on moonbase fix incorrect eth parent hashes on moonbase Oct 16, 2023
@github-actions
Copy link
Copy Markdown
Contributor

Coverage generated "Mon Oct 16 10:02:37 UTC 2023":
https://d3ifz9vhxc2wtb.cloudfront.net/pulls/2524/html/index.html

Master coverage: 87.39%
Pull coverage:

Copy link
Copy Markdown
Contributor

@noandrea noandrea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nbaztec nbaztec merged commit 6c7c10b into master Oct 17, 2023
@nbaztec nbaztec deleted the nish-fix-parent-hash branch October 17, 2023 08:17
rimbi pushed a commit that referenced this pull request Oct 18, 2023
* fix incorrect parent hashes

* apply to moonbase

* use correct block hash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants