Skip to content

add a smoke test to verify fix for the invalid parent hash in moonbase#2276

Merged
nbaztec merged 4 commits intomasterfrom
nish-smoke-test-parent-hash-fix
Jun 5, 2023
Merged

add a smoke test to verify fix for the invalid parent hash in moonbase#2276
nbaztec merged 4 commits intomasterfrom
nish-smoke-test-parent-hash-fix

Conversation

@nbaztec
Copy link
Copy Markdown
Contributor

@nbaztec nbaztec commented Apr 28, 2023

What does it do?

add a smoke test to verify fix for the invalid parent hash in moonbase

What important points reviewers should know?

This is related to the bug introduced in polkadot-evm/frontier#570 which we have been fixing via cherry-picking moonbeam-foundation/frontier#37 and now it is set to be mediated as the upstream PR polkadot-evm/frontier#1044

@nbaztec nbaztec added B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit labels Apr 28, 2023
@nbaztec nbaztec requested a review from timbrinded May 9, 2023 14:05
@github-actions
Copy link
Copy Markdown
Contributor

Coverage generated "Thu May 11 15:56:26 UTC 2023":
https://s3.amazonaws.com/moonbeam-coverage/pulls/2276/html/index.html

Master coverage: N/A
Pull coverage: 72.33%

@crystalin
Copy link
Copy Markdown
Collaborator

Can we merge it ?

@nbaztec nbaztec merged commit 39c54e8 into master Jun 5, 2023
@nbaztec nbaztec deleted the nish-smoke-test-parent-hash-fix branch June 5, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants