Merged
Conversation
notlesh
reviewed
Sep 22, 2023
Contributor
|
Looks good so far (I know it's not done yet :) ) |
92c8b6d to
88722b0
Compare
Contributor
|
Coverage generated "Tue Oct 10 10:10:49 UTC 2023": Master coverage: 87.39% |
02da56b to
a403c2d
Compare
rimbi
commented
Oct 4, 2023
rimbi
commented
Oct 4, 2023
rimbi
commented
Oct 4, 2023
rimbi
commented
Oct 9, 2023
6e5f333 to
e819d76
Compare
notlesh
reviewed
Oct 9, 2023
Contributor
notlesh
left a comment
There was a problem hiding this comment.
Looks good so far, haven't made it through everything yet but wanted to push my comments so far.
notlesh
reviewed
Oct 9, 2023
notlesh
reviewed
Oct 9, 2023
notlesh
approved these changes
Oct 9, 2023
Contributor
notlesh
left a comment
There was a problem hiding this comment.
LGTM. I left some comments that are worth reviewing though :)
added 4 commits
October 10, 2023 08:54
- `check --release` is done. - `check --tests` is in progress
- `check --tests` is in progress
- `check --tests` is done
This reverts commit 8fb8e24.
6547e2f to
7ee2ad9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Upgrades the dependencies
polkadot-sdkfrontiermoonkitormlpallet-crowdloansto the version
moonbeam-polkadot-v1.1.0.What important points reviewers should know?
Breaking Changes
Eth::newaccepts two additional parameters:pending_create_inherent_data_providers: which requires time inherent and ,in our case,ParachainInherentDataprovider. Since these are needed in a pending context, providing dummy values is enough.pending_consensus_data_provider: Through which we providednimbus author id(by getting it from the last best block) andvrfdigests.test/suites/dev/test-xcm-v3/test-mock-dmp-queue.ts.try-runtimesubcommand has been removed and migrated to the standalone-cli.AllowPaidExecutionFrombarrier now prevents multiple currency transfers.polkadot-sdkhas new names:xcm->staging-xcmxcm-executor->staging-xcm-executorxcm-builder->staging-xcm-builderkusama-runtime->staging-kusama-runtimeXcmVersionedXcmmessage in the ts tests has been renamed toStagingXcmVersionedXcmframe_system::Config,Indexwas renamed toNonceBlockNumber,HeaderandHoldIdentifierwere removedBlock,AliasersandRuntimeHoldReasonwere addedparas::Confighas a new associated typeOnNewHeadhrmp::Confighas a new associated typeChannelManagerpallet_message_queue::Confighas a new associated typeQueuePausedQuerybuild_storageandassimilate_storageis now provided viasp_runtime::BuildStorageinstead offrame_support::traits::GenesisBuildxcm_executor::traits::Convertwas replaced withxcm_executor::traits::ConvertLocationwhose APIs differ.improved_panic_error_reportingfeature insp_ioandchain-errorinparity-scale-codecto pass certain test cases.hrmp::WeightInfo::force_open_hrmp_channelaccepts a newu32argumentWeightTrader::buy_weightmethod takes an additionalXcmContextparameter.pallet_xcm_benchmarks::generic::Configrequires a new methodalias_originIs there something left for follow-up PRs?
start_full_nodeandstart_collatorAPIsmoonriver-nativeshould be renamed.What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?