Skip to content

Upgrade dependencies to polkadot-v1.1.0#186

Merged
rimbi merged 3 commits intomoonbeam-polkadot-v1.1.0from
cem-upgrade-to-polkadot-v1.1.0
Oct 9, 2023
Merged

Upgrade dependencies to polkadot-v1.1.0#186
rimbi merged 3 commits intomoonbeam-polkadot-v1.1.0from
cem-upgrade-to-polkadot-v1.1.0

Conversation

@rimbi
Copy link
Copy Markdown

@rimbi rimbi commented Sep 22, 2023

This is the PR upgrade dependencies to polkadot v1.1.0.

@rimbi rimbi self-assigned this Sep 22, 2023
@rimbi rimbi mentioned this pull request Sep 22, 2023
2 tasks
Cargo.lock Outdated
name = "frame-try-runtime"
version = "0.10.0-dev"
source = "git+https://github.com/paritytech/substrate?branch=polkadot-v1.0.0#948fbd2fd1233dc26dbb9f9bbc1d2cca2c03945d"
source = "git+https://github.com/moonbeam-foundation/polkadot-sdk?branch=moonbeam-polkadot-v1.1.0#893898cb26c2d279877288f6cf67799905c7cca0"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this pointing to the right commit? I couldn't find 893898cb26c2d279877288f6cf67799905c7cca0 within the latest commits of moonbeam-polkadot-v1.1.0 branch (it seems to be in another repo), and I guess that's because you haven't merged your PR with all the cherry-picks on our polkadot-sdk fork. You should first merge that one, and then update this reference to point to the latest commit in our moonbeam-polkadot-v1.1.0 branch inside the polkadot-sdk fork before merging this PR.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@Agusrodri
Copy link
Copy Markdown

The changes seem to be fine, but pay attention to the commit references. We should wait for moonbeam-foundation/polkadot-sdk#1 to be merged before merging this one (because you will need to update the references to the correct commit).

@rimbi
Copy link
Copy Markdown
Author

rimbi commented Sep 23, 2023

The changes seem to be fine, but pay attention to the commit references. We should wait for moonbeam-foundation/polkadot-sdk#1 to be merged before merging this one (because you will need to update the references to the correct commit).

Thanks Agustin, I will check and fix them before the merge.

@rimbi rimbi merged commit 7310969 into moonbeam-polkadot-v1.1.0 Oct 9, 2023
@rimbi rimbi deleted the cem-upgrade-to-polkadot-v1.1.0 branch October 9, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants