Add getters referendumStatus, referendumInfo for referenda precompile#2092
Merged
amarsinghcodes merged 31 commits intomasterfrom Feb 21, 2023
Merged
Add getters referendumStatus, referendumInfo for referenda precompile#2092amarsinghcodes merged 31 commits intomasterfrom
amarsinghcodes merged 31 commits intomasterfrom
Conversation
amarsinghcodes
commented
Feb 20, 2023
amarsinghcodes
commented
Feb 20, 2023
nanocryk
approved these changes
Feb 21, 2023
imstar15
pushed a commit
to AvaProtocol/moonbeam
that referenced
this pull request
May 16, 2023
* upgrade to v0.9.37 * fix tests * fix tests, update frontier * update frontier * update frontier * fix batch precompile tests * fix lint * fix tests * add root-testing pallet * fix length fees test * fix length fees test * fix ts tests * fmt * fix typo * fix statemine tests * fix ts test * fix tests * fix test * change test name * remove dev_mode, add call_index * bump * init * closed referendum info getter * make closed referendum info into a struct * init ongoing referendum info * everything but schedule address works * fix schedule address which does implement encode even if it is not transparent * fix comment --------- Co-authored-by: Nisheeth Barthwal <nbaztec@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes referendum{Status, Info} in precompiles
We have the following enum for ReferendumInfo:
So we expose this by adding a precompile getter for referendumStatus that tells us which variant the enum is. Then we have 3 more getters for each unique variant structure: