Conversation
crystalin
added
A0-pleasereview
runtime/moonbase/src/lib.rs
Outdated
| } | ||
|
|
||
| // AllPallets here implies all the specfied pallets in the runtime, except frame_system, | ||
| // AllPalletsReversedWithSystemFirst here implies all the specfied pallets in the runtime, except frame_system, |
There was a problem hiding this comment.
This comment isnt true anymore right? according to the naming
There was a problem hiding this comment.
Before we had AllPallets, which excluded Sytem. SHouldnt we use AllPalletsWithoutSystem if we want to maintain what we had?
There was a problem hiding this comment.
It seems Polkadot changed it to AllPalletsWIthSytem too: https://github.com/paritytech/polkadot/blob/41ab002d7451766324a9f314fee11c9c53314350/runtime/rococo/src/lib.rs#L150. So maybe we should just keep it like this, although I am not sure what the implications are
There was a problem hiding this comment.
Before we had AllPallets, which excluded Sytem. SHouldnt we use AllPalletsWithoutSystem if we want to maintain what we had?
No, because they changed how Executive works. Before it expected a tuple of pallets without system and added system internally. Now it doesn't add anything and expect system to be included.
|
Given that the reanchoring no longer works as before, this PR needs #1232 so that the tests pass |
… token 0.9.16 (#1274) * Add dual support in moonbase * Add tests for proving both representations are handled * Typescript tests for reanchoring * Cleaning and documenting * More docu * fix docu of teleports * EditorConfig * more editorconfig * Fix compilation error after cleanup * clean more * Toml sort * Modify tests to make them pass * pallet-identity to std and fix integration tests pallet maintenance mode
…e/moonbeam into jeremy-polkadot-v0.9.16
…e/moonbeam into jeremy-polkadot-v0.9.16
|
Just a thought, maybe we should include the evmtracing label on dependency updates? |
crystalin
added
A8-mergeoncegreen
notlesh
added
D1-audited👍
7 participants
What does it do?
Upgrade all our dependencies to match polkadot 0.9.16.
Left TODO :
0.9.15-1dependency upgrade #1193What important points reviewers should know?
Caused many changes, notably in parachain_staking.
I folowed the upgrade guide by replacing
AllPalletswithAllPalletsReversedWithSystemFirst. However, is this really the behavior we want?I used
()for new associated types which keeps current behavior, and added the required migration. Follow-up work might take advantage of the new functionality.MaxEncodedLenper default paritytech/substrate#10662Updated dependencies branches :
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?