DO NOT MERGE YET 0.9.15-1 dependency upgrade#1193
Closed
Conversation
tgmichel
added
A0-pleasereview
nanocryk
approved these changes
Jan 18, 2022
tgmichel
changed the title
0.9.15-1 dependency upgrade0.9.15-1 dependency upgrade
notlesh
reviewed
Jan 19, 2022
| prometheus_registry.as_ref(), | ||
| telemetry.as_ref().map(|x| x.handle()), | ||
| ); | ||
| env.set_soft_deadline(SOFT_DEADLINE_PERCENT); |
Contributor
There was a problem hiding this comment.
Is it the intention to set this to 100%? Wasn't it 50% previously? (This is dev mode...)
Contributor
There was a problem hiding this comment.
Oh, it's intentional -- you mentioned it in the description. Does this solve something in particular?
Contributor
There was a problem hiding this comment.
Over soft deadline skipping transactions will stop trying to add more transaction to the block. It's equivalent to our previous fix of removing transaction skipping entirely :p
# Conflicts: # Cargo.lock # runtime/moonbeam/Cargo.toml
Contributor
|
Should we close this since we already merged 0.9.16 and 0.9.17? @tgmichel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
0.9.15-1polkadot, substrate, cumulus and friends.ProposerFactoryand set it to100.What important points reviewers should know?
The only relevant change for parachains is democracy change in paritytech/substrate@d50e966 which is backported to
0.9.13and available on this0.9.15-1.Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?