Skip to content

Removed StorageCleaner precompile#1153

Merged
eshaben merged 4 commits intomasterfrom
ibbar/remove-storage-cleaner-precompile
Jul 1, 2025
Merged

Removed StorageCleaner precompile#1153
eshaben merged 4 commits intomasterfrom
ibbar/remove-storage-cleaner-precompile

Conversation

@ibbar
Copy link
Copy Markdown
Contributor

@ibbar ibbar commented Jun 17, 2025

Description

Removed StorageCleaner precompile from the non-specific.md page, as per this PR: moonbeam-foundation/moonbeam#3224

Checklist

  • I have added a label to this PR 🏷️
  • I have run my changes through Grammarly
  • If this requires translations for the moonbeam-docs-cn repo, I have created a ticket for the translations in Jira
  • If pages have been moved around, I have created an additional PR in moonbeam-mkdocs to update redirects
  • If pages have been moved around, I have run the move-pages.py script to move the pages and update the image paths on the chinese repo
    • After the script has been run, I have created an additional PR in moonbeam-docs-cn
  • If images have been added, I have run the compress-images.py script to compress the images.
  • If variables (in variables.yml) need to be updated (such as a name change), I have updated the moonbeam-docs-cn repo to use the new variables
  • If this page requires a disclaimer, I have added one

Corresponding PRs

Please link to any corresponding PRs here.

After Translation Requirements

  • Will need to create PR in moonbeam-docs repo to remove images
  • Will need to create PR in moonbeam-docs repo to remove variables
  • Will need to create PR in moonbeam-mkdocs repo to add redirects for Chinese site
  • No additional PRs are required after the translations are done

Items to be Updated

Please list any of the items that will need to be added or deleted after the translations are done here.

@ibbar ibbar requested a review from themacexpert June 17, 2025 15:30
@ibbar ibbar requested a review from a team as a code owner June 17, 2025 15:30
@ibbar ibbar added A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) B0 - Needs Review Pull request is ready for review labels Jun 17, 2025
@kapetan3sid kapetan3sid requested a review from 0xlukem June 17, 2025 15:36
Copy link
Copy Markdown
Contributor

@themacexpert themacexpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one more small thing that needs to be changed:

| [StorageCleaner](https://polkadot-evm.github.io/frontier/rustdocs/pallet_evm_precompile_storage_cleaner/struct.StorageCleanerPrecompile.html){target=\_blank} | 0x0000000000000000000000000000000000000403 |

in .snippets/text/builders/ethereum/canonical-contracts/non-specific/

Thanks!

Copy link
Copy Markdown
Contributor

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only know this because I added StorageCleaner to those pages once upon a time hahaha. Thank you!

Copy link
Copy Markdown
Contributor

@0xlukem 0xlukem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, Ibra. Once @dawnkelly09 and @themacexpert approve the changes that you made, we can move forward 🚀

Copy link
Copy Markdown
Contributor

@themacexpert themacexpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice job!

Copy link
Copy Markdown
Contributor

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dawnkelly09 dawnkelly09 added B1 - Ready to Merge Pull request is ready to be merged and removed B0 - Needs Review Pull request is ready for review labels Jul 1, 2025
@eshaben eshaben merged commit c9961c5 into master Jul 1, 2025
2 checks passed
@albertov19 albertov19 deleted the ibbar/remove-storage-cleaner-precompile branch March 13, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) B1 - Ready to Merge Pull request is ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants