Skip to content

Naming pass: follow-up fixes from the #994 review - #995

Merged
mohanpednekar merged 5 commits into
mainfrom
claude/naming-review-fixes
Nov 4, 2026
Merged

mohanpednekar merged 5 commits into
mainfrom
claude/naming-review-fixes

Conversation

@mohanpednekar

Copy link
Copy Markdown
Owner

Summary

Test plan

  • yarn test passes (2214/2214)
  • Visual-regression --update-snapshots passes 4/4 against the existing baselines, so no PNG changes. This ran on the sandbox's Chromium 1243 through a temporary executablePath config.
  • Three other e2e specs (golden-path, autobuyer-reload, data-lake) fail in the same way without this PR's changes. Their causes predate this PR: data-lake uses getByLabelText, which Playwright doesn't have, and the other two look for an old h1 / button name. Not addressed here.

Documentation


Generated by Claude Code

…s ping, leftovers, variant test

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WvzZB7A6LFCYnhw8YhQfSW
…e tooltips

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WvzZB7A6LFCYnhw8YhQfSW

Copy link
Copy Markdown
Owner Author

Adversarial review of f04b059: NEEDS CHANGES. The source fixes and the new variant test were verified, and the test was confirmed to fail when the variant is purge. What remained was doc leftovers: COMPONENTS_REFERENCE.md:98 ("tap to generate a bit" and the old Speed popover labels) and :115 ("Reset Pool"), CLAUDE.md:662 ("Cores … Auto-merge") and MAINPAGE_REFERENCE.md:438-443, plus two "merge" tooltips.

Fixed in ad3dac8, and yarn test passes (2214).


Generated by Claude Code

Copy link
Copy Markdown
Owner Author

Adversarial review of ad3dac8: NEEDS CHANGES. All six earlier fixes checked out. Still to fix: two reference docs quoted the "🤖 Auto-merge" row label and "Unlock Auto-merge", and one sentence in ECONOMY_REFERENCE.md:1211 used "Cores" for the Power-chain entity. There was also a stale code comment.

All of these are fixed in bbcd76f (docs and comments only). Function-name tables that describe code identifiers are deliberately left as they are.


Generated by Claude Code

Copy link
Copy Markdown
Owner Author

Adversarial review of bbcd76f: APPROVE.

  • Every earlier finding is fixed, and each fix was checked against the source.
  • A sweep of the whole PR found no player-facing doc quote that disagrees with the source.
  • No engine, state or economy files changed.
  • yarn test passes, 2214/2214.

Generated by Claude Code

@mohanpednekar
mohanpednekar marked this pull request as ready for review November 4, 2026 03:53
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T06:34:06.161588Z 0e8a301 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Co-authored-by: Mohan Namdeo Pednekar <mohanpednekar@users.noreply.github.com>

# Conflicts:
#	CLAUDE.md
#	docs/COMPONENTS_REFERENCE.md
#	docs/ECONOMY_REFERENCE.md
#	docs/FOUNDRY_MECHANICS_REFERENCE.md
#	docs/MAINPAGE_REFERENCE.md
Base automatically changed from claude/purge-code-rename to main November 4, 2026 06:32
@mohanpednekar
mohanpednekar merged commit 37a1056 into main Nov 4, 2026
8 checks passed
@mohanpednekar
mohanpednekar deleted the claude/naming-review-fixes branch November 4, 2026 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants