Enhance delete resource dialog #13497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
#modxbughunt #3points to @lawrenz1337 |
rtripault
added a commit
that referenced
this pull request
Jul 7, 2017
* upstream/pr/13497: fix(Resource) delete dialog UI
Contributor
|
Working as advertised, merged. Thanks! |
Contributor
|
#modxbughunt #1point to @rtripault |
opengeek
added a commit
that referenced
this pull request
Nov 10, 2017
Merge remote-tracking branch 'origin/pr/13669' into 2.6.x * origin/pr/13669: Fix javascript issue on resources containing a quote sign - Introduced in #13497
opengeek
added a commit
that referenced
this pull request
Nov 28, 2017
* origin/2.x: Avoid fatal error if a modFieldTag is processed without a resource Fixing 'Flush Your Permissions' in topmenu Change the style to pre-wrap Allow callback if nothing is selected Check if contentEl exists before using it Fix CLI installation on MySQL < 5.6 to use MyISAM engine Fix invokeEvent call for new OnResourceCacheUpdate event Revert newline patch and add white-space style Replace newline with br tag Issue #13668: Fixed wrong title format in different Manager pages Reset image_width and image_height, remove introduced file_width and file_height Fix javascript issue on resources containing a quote sign - Introduced in #13497 Update version for 2.6.1 development Update version for 2.6.0-pl release Fixed issue introduced by #13506 preventing to download 2 packages in a row Update welcome page URL Update translations
wuuti
pushed a commit
to wuuti/revolution
that referenced
this pull request
Feb 7, 2018
wuuti
pushed a commit
to wuuti/revolution
that referenced
this pull request
Feb 7, 2018
wuuti
pushed a commit
to wuuti/revolution
that referenced
this pull request
Feb 7, 2018
wuuti
pushed a commit
to wuuti/revolution
that referenced
this pull request
Feb 9, 2018
wuuti
pushed a commit
to wuuti/revolution
that referenced
this pull request
Feb 9, 2018
wuuti
pushed a commit
to wuuti/revolution
that referenced
this pull request
Feb 9, 2018
wuuti
pushed a commit
to wuuti/revolution
that referenced
this pull request
Feb 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Added pagetitle and ID of the deleted resource to the delete dialog
Why is it needed?
Just a continuation of #13475. The default UI for 'Delete' dialog doesn't show the name and ID and it is pretty easy to forget which resource you are trying to delete.
Related issue(s)/PR(s)
#13475 #13448