Fix issue #13448 - Enhance duplicate dialog #13475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawrenz1337
changed the title
Collaborator
|
Hey @lawrenz1337, thanks for your contribution. Have you submitted the CLA for MODX before? That can be found here: https://develop.modx.com/contribute/cla/ |
Contributor
Author
|
@Mark-H No I haven't, I will do it right now. |
Contributor
|
can this be reviewed and merged during the 2nd modxbughunt? |
Contributor
|
@wuuti I'll check it today |
Contributor
|
#modxbughunt |
Contributor
|
#modxbughunt #1point to @alroniks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
It shows the pagetitle and ID of the resource in the 'Duplicate' dialog
Why is it needed?
The default UI for 'Duplicate' dialog doesn't show the name and ID and it is pretty easy to forget which reource you are trying to duplicate.
Related issue(s)/PR(s)
Issue #13448