Skip to content

Remove incorrect unit-casting #4053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Remove incorrect unit-casting #4053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29886c3
Remove incorrect unit-casting.
HansOlsson Oct 31, 2022
a792f6e
And add unit for M
HansOlsson Jun 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Modelica/Magnetic/FluxTubes/Shapes/HysteresisAndMagnets/GenericHystTellinenHard.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,21 +7,21 @@ model GenericHystTellinenHard
//Hysteresis parameter
parameter SI.MagneticFluxDensity Br=1.2 "Remanence" annotation (Dialog(group="Hysteresis", groupImage="modelica://Modelica/Resources/Images/Magnetic/FluxTubes/Shapes/HysteresisAndMagnets/GenericHystTellinenHard/HardMagneticHysteresis.png"));
parameter SI.MagneticFieldStrength Hc=5e5 "Coercitivity" annotation (Dialog(group="Hysteresis"));
parameter Real M = 10/Hc "Slope of tanh()-function" annotation (Dialog(group="Hysteresis"));
parameter Real M(final unit="m/A") = 10/Hc "Slope of tanh()-function" annotation (Dialog(group="Hysteresis"));
parameter Real K=1 "Slope of hysteresis in the saturation region (K*mu_0)" annotation (Dialog(group="Hysteresis"));

protected
final parameter SI.MagneticFluxDensity eps = Br/1000;
//final parameter Real mu0(final unit="N/A2") = K*mu_0;
final parameter SI.MagneticFieldStrength H0= 0.5*log((1+mu0*Hc/Br)/(1-mu0*Hc/Br)) + M*Hc;
final parameter Real H0= 0.5*log((1+mu0*Hc/Br)/(1-mu0*Hc/Br)) + M*Hc;
constant SI.MagneticFieldStrength unitH = 1;

Real tanhR;
Real tanhF;

equation
tanhR = tanh((M*H - H0)/unitH);
tanhF = tanh((M*H + H0)/unitH);
tanhR = tanh(M*H - H0);
tanhF = tanh(M*H + H0);
hystR = Br*tanhR + mu0*H - eps/2;
hystF = Br*tanhF + mu0*H + eps/2;

Expand Down
4 changes: 2 additions & 2 deletions Modelica/Magnetic/FluxTubes/Shapes/HysteresisAndMagnets/GenericHystTellinenSoft.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ protected
constant SI.MagneticFieldStrength unitH = 1;

equation
hystR = Js*tanh((M*Hstat - H0)/unitH) + mu0*Hstat - eps/2;
hystF = Js*tanh((M*Hstat + H0)/unitH) + mu0*Hstat + eps/2;
hystR = Js*tanh(M*Hstat - H0) + mu0*Hstat - eps/2;
hystF = Js*tanh(M*Hstat + H0) + mu0*Hstat + eps/2;

annotation (defaultComponentName="core", Documentation(info="<html>
<p>Flux tube element for modeling soft magnetic materials with ferromagnetic and dynamic hysteresis (eddy currents). The ferromagnetic hysteresis behavior is defined by the <a href=\"modelica://Modelica.Magnetic.FluxTubes.UsersGuide.Hysteresis.StaticHysteresis.Tellinen\">Tellinen hysteresis model</a>. The shape of the limiting hysteresis loop (see Fig. 1) is described by simple hyperbolic tangent functions with 4 parameters. Therefore, the hysteresis shape variety is limited but the parameterization of the model is very simple and the model is relatively fast and robust. The rising (hyst<sub>R</sub>) and falling (hyst<sub>F</sub>) branches of the limiting hysteresis loop are defined by the following equations.</p>
Expand Down