Remove incorrect unit-casting #4053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HansOlsson
added
the
L: Magnetic.FluxTubes
Contributor
christiankral
left a comment
christiankral
left a comment
There was a problem hiding this comment.
Two comments:
- The constant
unitHis then not needed any more and can be removed from both models - The parameter
parameter Real M = 10/Hccould be changed toparameter Real(final unit="m/A") M = 10/Hc
hubertus65
approved these changes
Apr 6, 2023
Contributor
|
Sorry this is a task for @ThomasBoedrich and Johannes Ziske. |
Contributor
Author
True, but that would sort of break compatibility (using an inherited unitH is bad; but formally allowed) - so I delay that.
Ok, but doesn't seem that necessary. |
Contributor
Author
|
Adding unit just in case. |
Contributor
Author
Can you re-examine - it seems that a new approval is needed after change. |
This was referenced Jun 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basic issue is that
H0shouldn't be seen as a magnetic field strength, but as a dimensionless value (which makes sense given that it is the result of a logarithm). That implies that the argument to tanh is already dimensionless - when M has the unit of inverse magnetic field strength.The commit also makes the two models more similar.
As far as I can tell this issue was already present in the original commit of these models.