-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
docs: indicate 'exports' interface does not work in browsers #5181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
voxpelli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add the documentation within the exports section of the documentation? https://mochajs.org/#exports
|
Thank you @voxpelli for the feedback! I will make the requested changes and update the documentation within the exports section as soon as possible. |
bcdd857 to
0409d42
Compare
|
Hi @voxpelli, I’ve moved the note about the Thanks for the feedback! |
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one small stylistic change that I think we'll want to avoid. Thanks! 📝
Update Documentation for "Exports" Interface Browser Incompatibility
Description
This pull request updates the Mocha documentation to indicate that the "exports" interface does not work in browser environments. The following changes have been made:
docs/index.md: Added a note under the relevant section explaining the limitation with the "exports" interface.docs/API.md: Added a note under the "exports" interface section explaining its incompatibility with browsers.References
Testing
Please review and let me know if any further changes are needed.
Thank you!