Revert default glob to match Mocha-5.2 #3754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old glob 'test' would allow 'test.js' to be used by default (rather than requiring file be placed inside "test" directory. Fixes #3750
plroebuck
added
area: usability
Contributor
Author
|
This is just the patch itself. Do we want to document this "feature", or simply treat it as a |
Member
|
no, whatever, it's fine. |
14 tasks
This was referenced Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
The old glob 'test' would allow "test.js" to be used by default (rather than requiring spec file be
placed inside "test" directory).
In minimalist repos, users were simply using "test.js" rather than "test/<file>.js", allowing...
Alternate Designs
NA
Why should this be in core?
NA - already there
Benefits
Restore compatibility with previous releases.
Prevent a boatload of more issues from minimalist repositories using Mocha.
Possible Drawbacks
None
Applicable issues
Fixes #3750
semver-patch